Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab CI: set alpaka_DEBUG #2133

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

GitLab CI: set alpaka_DEBUG #2133

wants to merge 1 commit into from

Conversation

SimeonEhrig
Copy link
Member

@SimeonEhrig SimeonEhrig commented Sep 5, 2023 •
edited by bernhardmgruber
Loading

j-stephan
j-stephan reviewed Sep 5, 2023
View reviewed changes
script/job_generator/generate_job_yaml.py
@@ -287,6 +288,11 @@ def job_variables(job: Dict[str, Tuple[str, str]]) -> Dict[str, str]:
variables["ALPAKA_CI_CMAKE_VER"] = job[CMAKE][VERSION]
variables["ALPAKA_BOOST_VERSION"] = job[BOOST][VERSION]

if job[BUILD_TYPE][VERSION] == CMAKE_DEBUG:
variables["alpaka_DEBUG"] = 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also alpaka_DEBUG = 1. Or is this enabled somewhere else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to test both, I need to add the alpaka debug variable to the parameter set of the job generator. Or extend the BUILD_TYPE type to CMAKE_DEBUG1 and CMAKE_DEBUG2.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the parameter set would be the best fit here.

@bernhardmgruber
Copy link
Member

Please rebase, I think you are missing my PR that fixed one of the bugs: #2127

@SimeonEhrig
Copy link
Member Author

@bernhardmgruber I rebased. But there is still the problem with the heavy job output.

@bernhardmgruber
Copy link
Member

@SimeonEhrig thx! I don't have a quick solution ready and unfortunately no time the next days. Let's discuss this in the next alpaka VC.

@bernhardmgruber
Copy link
Member

@SimeonEhrig let's think about this after the release!

@psychocoderHPC psychocoderHPC added this to the 1.2.0 milestone Jan 29, 2024
@psychocoderHPC
Copy link
Member

@SimeonEhrig Is this PR outdated or should it be finished?

@SimeonEhrig SimeonEhrig modified the milestones: 1.2.0, 2.0.0 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-stephan j-stephan j-stephan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Type:Testing
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Add CI jobs with alpaka_DEBUG=2
4 participants
@SimeonEhrig @bernhardmgruber @psychocoderHPC @j-stephan