Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heat Equation 2D Bug Fixes #2384

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Heat Equation 2D Bug Fixes #2384

merged 1 commit into from
Sep 18, 2024

Conversation

ikbuibui
Copy link
Contributor

@ikbuibui ikbuibui commented Sep 17, 2024 •
edited
Loading

Fix race condition in image write
Improve stability condition
Dont validate for guard cells
Improve contrast in image write
Make image changes more obvious

@ikbuibui ikbuibui changed the title Fix race condition in image write Heat Equation 2D Bug Fixes Sep 17, 2024
@psychocoderHPC
Copy link
Member

@ikbuibui I stopped the CI because jobs already failed

        for(uint32_t i = 1; i < extents[1] - 1; ++i)
                                ^~~~~~~
                                extent
/__w/alpaka/alpaka/example/heatEquation2D/src/analyticalSolution.hpp:33:21: note: 'extent' declared here
    T_Extent const& extent,

@psychocoderHPC psychocoderHPC added this to the 1.2.0 milestone Sep 17, 2024
@ikbuibui
Fix race condition in image write
64251a3 
Improve stability condition
Dont validate for guard cells
Improve contrast in image write
Make changes more obvious
@psychocoderHPC psychocoderHPC merged commit 6f759e3 into alpaka-group:develop Sep 18, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychocoderHPC psychocoderHPC psychocoderHPC approved these changes

Assignees
No one assigned
Labels
Type:Bug Type:Example
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ikbuibui @psychocoderHPC