Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vertex to express #191

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Conversation

Rajil1213
Copy link
Contributor

Description

This PR renames all instances of vertex to express as per the latest product naming decision.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

@Rajil1213 Rajil1213 added the refactor Reworking code to improve structure or performance label Jul 31, 2024
@Rajil1213 Rajil1213 self-assigned this Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

The author of this PR, Rajil1213, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

prajwolrg
prajwolrg previously approved these changes Jul 31, 2024
@Rajil1213
Copy link
Contributor Author

@pramodkandel we'll also need to rename the repo to express-core.

Should we also consider renaming the master branch to main? ref1 ref2

CC: @delbonis

@Rajil1213 Rajil1213 force-pushed the refactor/rename-vertex-to-express branch from 2eb4b4d to 7afaf2f Compare July 31, 2024 10:22
@delbonis
Copy link
Contributor

Renaming things this deep is a mess. Should probably wait until we can merge some of the other pending PRs so there's less that gets horribly broken.

@Rajil1213
Copy link
Contributor Author

Renaming things this deep is a mess. Should probably wait until we can merge some of the other pending PRs so there's less that gets horribly broken.

I mostly agree. This one affects everybody but I don't know when is a "good" time to merge this one. We should probably set some sort of deadline. I imagine there will always be some PR that will be affected by this change since there are several of us working on the project concurrently. And the more PRs get merged, the deeper these changes will be.

@delbonis
Copy link
Contributor

I guess we could just bite the bullet and go for it now, I'm fine to merge it. I also have perms to rename the repo.

As for the branch name, I see other rollup projects use master (I checked zksync, aztec). It's a bit of a tossup. I completely support the spirit of inclusion, but it'd be more of a disruption with the integrations already set up.

@delbonis
Copy link
Contributor

The crate names are getting rather long, do you think we should remove the alpen- prefix on them now that we're not using a codename anymore and we're planning on marketing it directly?

@Rajil1213
Copy link
Contributor Author

it'd be more of a disruption with the integrations already set up.

I can update the references in the CI workflows. We'll have to update our refs as well, and Github does make it pretty easy to change the default branch. Are there any other integrations that you have set up?

do you think we should remove the alpen- prefix on them

Yeah, I think we should. None of the other repos (reth, citrea) use org prefixes. I'll update the PR tomorrow with this. I think it amounts to fundamentally the same type of change as updating vertex to express.

It should also be okay to rename the repo to express-core or simply express if you have the permissions (maybe post on slack when you're done like you did for nero -> vertex?). There's also a task on Jira for this.

@delbonis
Copy link
Contributor

Leave the branch name as-is. The repo name should keep the -core suffix since we might decide to brand the EVM chain separately as "Express EVM" or something along those lines. ("Expressium"? I have no idea.) It might break the Slack integration but I guess we'll have to see.

@delbonis delbonis merged commit cf3e358 into master Jul 31, 2024
22 of 24 checks passed
@Rajil1213 Rajil1213 deleted the refactor/rename-vertex-to-express branch September 7, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Reworking code to improve structure or performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants