-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename vertex
to express
#191
Conversation
The author of this PR, Rajil1213, is not an activated member of this organization on Codecov. |
@pramodkandel we'll also need to rename the repo to Should we also consider renaming the CC: @delbonis |
2eb4b4d
to
7afaf2f
Compare
Renaming things this deep is a mess. Should probably wait until we can merge some of the other pending PRs so there's less that gets horribly broken. |
I mostly agree. This one affects everybody but I don't know when is a "good" time to merge this one. We should probably set some sort of deadline. I imagine there will always be some PR that will be affected by this change since there are several of us working on the project concurrently. And the more PRs get merged, the deeper these changes will be. |
I guess we could just bite the bullet and go for it now, I'm fine to merge it. I also have perms to rename the repo. As for the branch name, I see other rollup projects use |
The crate names are getting rather long, do you think we should remove the |
I can update the references in the CI workflows. We'll have to update our refs as well, and Github does make it pretty easy to change the default branch. Are there any other integrations that you have set up?
Yeah, I think we should. None of the other repos (reth, citrea) use org prefixes. I'll update the PR tomorrow with this. I think it amounts to fundamentally the same type of change as updating It should also be okay to rename the repo to |
Leave the branch name as-is. The repo name should keep the |
Description
This PR renames all instances of
vertex
toexpress
as per the latest product naming decision.Type of Change
Checklist