-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create basic scaffolding for bridge core impl #192
Create basic scaffolding for bridge core impl #192
Conversation
The author of this PR, Rajil1213, is not an activated member of this organization on Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of these crates don't really have a purpose being created until we actually have something to put in there. To me creating scaffolding should involve at least going as far as types and traits in trying to work out how the components will go together, leaving the specifics incomplete like I did creating all the chain/state types in the state crate and stuff. What bridge-exec
and bridge-rpc-service
will actually look like is completely unspecified because not only are the details unspecified, but the components they interface with are also still mostly unimplemented as of this PR.
I think right now we should just be focusing on (1) doing the transaction assembly and (2) pulling in work from the alpen_
RPC interface. Let's wait until we move the tickets into JIRA to define more concrete bridge impl tasks.
Also I would be reorganizing the binary crates shouldn't be done in a PR like this, it's breaking changes with other PRs so we should avoid bundling it with new stuff. I still don't really like that structure.
@delbonis I agree on all the points you've raised. As discussed in the DMs, this PR is more about getting your feedback on the overall project structure before I start writing out the traits. The issue #169 for this was created some time ago. For the |
This is as per [cargo package layout](https://doc.rust-lang.org/cargo/guide/project-layout.html)
a531961
to
9809f78
Compare
Closing this PR to prevent wasteful CI runs and will create a new PR once the core traits are written out. |
Description
This PR adds a very basic project structure (crates, crate-docs) for the bridge-core implementation. The traits will be added via another PR to issue #169.
As part of this PR, all the binaries have been moved to the
bin/
directory as per the cargo package layout convention.Type of Change
Checklist
Related Issues
Closes #168 #169