Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-676: sets a CI autoupdate cron job #550

Merged
merged 2 commits into from
Dec 24, 2024
Merged

STR-676: sets a CI autoupdate cron job #550

merged 2 commits into from
Dec 24, 2024

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Dec 18, 2024

Description

Spinoff of #537.

Adds a CI cron job to do an automated PR monthly.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update
  • New CI action

Notes to Reviewers

Depends on https://github.com/organizations/alpenlabs/settings/actions and check Allow GitHub Actions to create and approve pull requests.

If you look closely, you might find a Ramanujan number hidden in this PR.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

STR-676
STR-630

@storopoli storopoli requested a review from a team as a code owner December 18, 2024 19:41
@storopoli storopoli marked this pull request as draft December 18, 2024 19:42
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.74%. Comparing base (5008f3d) to head (870f610).
Report is 4 commits behind head on main.

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   56.76%   56.74%   -0.03%     
==========================================
  Files         306      309       +3     
  Lines       31263    31387     +124     
==========================================
+ Hits        17747    17809      +62     
- Misses      13516    13578      +62     

see 26 files with indirect coverage changes

delbonis
delbonis previously approved these changes Dec 18, 2024
Copy link
Contributor

@Rajil1213 Rajil1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few nits.

.github/workflows/cron-nightly-rust.yml Outdated Show resolved Hide resolved
.github/workflows/cron-nightly-rust.yml Show resolved Hide resolved
@delbonis
Copy link
Contributor

Agree with ^comments.

@storopoli storopoli marked this pull request as ready for review December 20, 2024 17:47
@storopoli storopoli enabled auto-merge December 23, 2024 10:38
@storopoli storopoli added this pull request to the merge queue Dec 24, 2024
Merged via the queue into main with commit 1dd0494 Dec 24, 2024
20 checks passed
@storopoli storopoli deleted the STR-676-ci branch December 24, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants