Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump bdk wallet & friends to 1.0.0 #553

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Dec 19, 2024

Description

BDK 1.0.0 has been released. No more betas!
See: https://github.com/bitcoindevkit/bdk/releases/tag/wallet-1.0.0

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

@storopoli storopoli requested review from a team as code owners December 19, 2024 20:22
Cargo.toml Show resolved Hide resolved
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 38.59649% with 35 lines in your changes missing coverage. Please review.

Project coverage is 56.34%. Comparing base (6a47763) to head (b1e42ff).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
bin/strata-cli/src/cmd/deposit.rs 0.00% 8 Missing ⚠️
bin/strata-cli/src/cmd/drain.rs 0.00% 7 Missing ⚠️
bin/strata-cli/src/cmd/recover.rs 0.00% 7 Missing ⚠️
crates/util/python-utils/src/taproot.rs 0.00% 7 Missing ⚠️
bin/strata-cli/src/cmd/send.rs 0.00% 6 Missing ⚠️
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
- Coverage   56.37%   56.34%   -0.04%     
==========================================
  Files         309      309              
  Lines       32022    32014       -8     
==========================================
- Hits        18054    18038      -16     
- Misses      13968    13976       +8     
Files with missing lines Coverage Δ
bin/strata-cli/src/signet/backend.rs 0.00% <ø> (ø)
crates/util/python-utils/src/drt.rs 87.17% <100.00%> (-0.07%) ⬇️
bin/strata-cli/src/cmd/send.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/cmd/drain.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/cmd/recover.rs 0.00% <0.00%> (ø)
crates/util/python-utils/src/taproot.rs 60.99% <0.00%> (+0.25%) ⬆️
bin/strata-cli/src/cmd/deposit.rs 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

delbonis
delbonis previously approved these changes Dec 19, 2024
AaronFeickert
AaronFeickert previously approved these changes Dec 20, 2024
Copy link
Contributor

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bin/strata-cli/src/cmd/recover.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Zk2u Zk2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

Cargo.toml Show resolved Hide resolved
bin/strata-cli/src/cmd/recover.rs Outdated Show resolved Hide resolved
bin/strata-cli/src/cmd/recover.rs Outdated Show resolved Hide resolved
@storopoli storopoli dismissed stale reviews from delbonis and AaronFeickert via 814d018 January 6, 2025 16:49
@storopoli storopoli force-pushed the deps/bdk-1.0.0 branch 2 times, most recently from 814d018 to 3f89607 Compare January 6, 2025 16:50
Zk2u
Zk2u previously approved these changes Jan 6, 2025
Copy link
Contributor

@Zk2u Zk2u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@storopoli storopoli enabled auto-merge January 6, 2025 16:57
AaronFeickert
AaronFeickert previously approved these changes Jan 6, 2025
Copy link
Contributor

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Commit: 24da068

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 7,239,295
EL_BLOCK 100,761
CL_BLOCK 56,358
L1_BATCH 12,459,517
L2_BATCH 5,443
CHECKPOINT 16,119

@Zk2u
Copy link
Contributor

Zk2u commented Jan 7, 2025

@storopoli needs conflict resolution

@storopoli storopoli dismissed stale reviews from AaronFeickert and Zk2u via b1e42ff January 7, 2025 10:31
@storopoli storopoli added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit cee6ca6 Jan 7, 2025
15 of 18 checks passed
@storopoli storopoli deleted the deps/bdk-1.0.0 branch January 7, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants