Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STR-782: add a warning about partial MuSig2 verification #558

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

AaronFeickert
Copy link
Contributor

Description

This PR updates the documentation for partial MuSig2 signature verification to caution against assuming unforgeability of partial signatures.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@AaronFeickert AaronFeickert requested a review from a team as a code owner December 23, 2024 18:14
@AaronFeickert AaronFeickert force-pushed the partial-verification-docs branch from e29df74 to f9155e2 Compare December 23, 2024 18:18
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.29%. Comparing base (506fd5c) to head (afd48f8).
Report is 5 commits behind head on main.

@@            Coverage Diff             @@
##             main     #558      +/-   ##
==========================================
- Coverage   57.33%   57.29%   -0.05%     
==========================================
  Files         309      309              
  Lines       31510    31510              
==========================================
- Hits        18067    18053      -14     
- Misses      13443    13457      +14     
Files with missing lines Coverage Δ
crates/bridge-sig-manager/src/operations.rs 96.70% <ø> (ø)

... and 4 files with indirect coverage changes

Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK afd48f8

@Rajil1213 Rajil1213 added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit b7e746c Dec 27, 2024
18 checks passed
@Rajil1213 Rajil1213 deleted the partial-verification-docs branch December 27, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants