-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass RollupParams as an argument in prover-client
#559
base: main
Are you sure you want to change the base?
Conversation
21a42db
to
bb3b3e4
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #559 +/- ##
==========================================
+ Coverage 57.31% 57.37% +0.05%
==========================================
Files 309 308 -1
Lines 31510 31494 -16
==========================================
+ Hits 18061 18069 +8
+ Misses 13449 13425 -24
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment on what types we're parsing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 505ee17
Description
RollupParams
was hardcoded in a file insideprover-client
. This PR fixes that by passing it as an argument.Type of Change
Notes to Reviewers
Checklist
Related Issues