Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block template manager and rpc #560

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

block template manager and rpc #560

wants to merge 4 commits into from

Conversation

sapinb
Copy link
Contributor

@sapinb sapinb commented Dec 24, 2024

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

STR-805

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 323 lines in your changes missing coverage. Please review.

Project coverage is 56.73%. Comparing base (ed5319c) to head (9e7e4d0).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
crates/block-assembly/src/worker.rs 0.00% 79 Missing ⚠️
crates/block-assembly/src/manager.rs 0.00% 51 Missing ⚠️
crates/block-assembly/src/types.rs 0.00% 46 Missing ⚠️
crates/block-assembly/src/handle.rs 0.00% 44 Missing ⚠️
crates/consensus-logic/src/duty/block_assembly.rs 0.00% 38 Missing ⚠️
bin/strata-client/src/rpc_server.rs 0.00% 37 Missing ⚠️
bin/strata-client/src/main.rs 0.00% 24 Missing ⚠️
crates/rpc/utils/src/lib.rs 0.00% 3 Missing ⚠️
crates/state/src/header.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
+ Coverage   56.68%   56.73%   +0.04%     
==========================================
  Files         303      313      +10     
  Lines       31002    31812     +810     
==========================================
+ Hits        17575    18047     +472     
- Misses      13427    13765     +338     
Files with missing lines Coverage Δ
crates/rpc/api/src/lib.rs 0.00% <ø> (ø)
crates/state/src/header.rs 85.14% <0.00%> (-1.99%) ⬇️
crates/rpc/utils/src/lib.rs 0.00% <0.00%> (ø)
bin/strata-client/src/main.rs 0.00% <0.00%> (ø)
bin/strata-client/src/rpc_server.rs 0.00% <0.00%> (ø)
crates/consensus-logic/src/duty/block_assembly.rs 45.49% <0.00%> (-2.15%) ⬇️
crates/block-assembly/src/handle.rs 0.00% <0.00%> (ø)
crates/block-assembly/src/types.rs 0.00% <0.00%> (ø)
crates/block-assembly/src/manager.rs 0.00% <0.00%> (ø)
crates/block-assembly/src/worker.rs 0.00% <0.00%> (ø)

... and 123 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant