-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STR-885 Fix Bridge Client Bug and add functional Test #564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way errors are reasoned about here needs to be improved, it's written assuming they can't really happen.
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #564 +/- ##
==========================================
- Coverage 56.78% 56.55% -0.24%
==========================================
Files 308 309 +1
Lines 32397 32460 +63
==========================================
- Hits 18398 18359 -39
- Misses 13999 14101 +102
|
efe5cd7
to
92849d0
Compare
bfce305
to
91e61df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 91e61df
I think this needs to be rebased and tweaked now that @evgenyzdanovich's PR has been merged? |
Commit: b4f04b2 SP1 Performance Test Results
|
9a5c2ee
to
dd547e5
Compare
dd547e5
to
a7bff9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 083c1e5
Description
The nature of websocket client is that it requires restart once the connection drops. Due to this
bridge-client
stops if the connection tostrata-client
drops which is not the desired and must be handled. This PR fixes the bug by using managed connection pool calleddeadpool
.Note
The functional test deliberately contains duplicated code which can be fixed after STR-734 is merged. STR-734 contains
BridgeTestBase
class that will be utilized by this functional test after rebase. I opened this PR to discuss the bug fix partType of Change
Notes to Reviewers
Checklist
Related Issues
STR-885