Create RawBitcoinTx wrapper type for Transaction #605
+134
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prajwolrg
force-pushed
the
refactor/l1tx
branch
2 times, most recently
from
38589c9 to
00c4308
Compare
prajwolrg
changed the title
|
Commit: ca87374 SP1 Performance Test Results
|
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #605 +/- ##
==========================================
- Coverage 56.68% 56.63% -0.05%
==========================================
Files 313 313
Lines 32505 32540 +35
==========================================
+ Hits 18425 18429 +4
- Misses 14080 14111 +31
|
|
Are we somehow doing some basic checks as in https://docs.rs/bitcoin/0.32.5/bitcoin/consensus/trait.Decodable.html#impl-Decodable-for-Vec%3CTransaction%3E ? |
|
I'm soft against putting nontrivial structural checks which we "don't own" close to the database like this. The database layer should be concerned with just ensuring that the general shape of the data is sane, not that it's semantically correct. |
delbonis
requested changes
Jan 10, 2025
prajwolrg
changed the title
delbonis
previously approved these changes
Jan 14, 2025
storopoli
requested changes
Jan 14, 2025
prajwolrg
force-pushed
the
refactor/l1tx
branch
from
6dc1126 to
670e539
Compare
bewakes
approved these changes
Jan 15, 2025
prajwolrg
changed the title
storopoli
requested changes
Jan 15, 2025
Comment on lines
+825
to
+828
| /// Represents a raw, byte-encoded Bitcoin transaction with custom [`Arbitrary`] support. | ||
| /// Provides conversions (via [`TryFrom`]) to and from [`Transaction`]. | ||
| #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize, BorshSerialize, BorshDeserialize)] | ||
| pub struct RawBitcoinTx(Vec<u8>); |
There was a problem hiding this comment.
This should come before the impls. Can you move it up?
Comment on lines
+750
to
+762
| impl TryFrom<RawBitcoinTx> for Transaction { | ||
| type Error = encode::Error; | ||
| fn try_from(value: RawBitcoinTx) -> Result<Self, Self::Error> { | ||
| deserialize(&value.0) | ||
| } | ||
| } | ||
|
|
||
| impl TryFrom<&RawBitcoinTx> for Transaction { | ||
| type Error = encode::Error; | ||
| fn try_from(value: &RawBitcoinTx) -> Result<Self, Self::Error> { | ||
| deserialize(&value.0) | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you add trivial tests:
- case when the transaction is valid in bytes and the
TryFromsucceeds - case when the transaction is invalid in bytes and the
TryFromfails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Notes to Reviewers
Checklist
Related Issues