-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Ignore unpinned-uses to github cleanup actions #608
Conversation
Commit: c651589 SP1 Performance Test Results
|
I think the easiest solution is to just add We could also open an issue/PR upstream though. |
As @Rajil1213 suggested, I've just commented the cleanup actions with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #608 +/- ##
==========================================
- Coverage 56.82% 56.77% -0.06%
==========================================
Files 308 308
Lines 32383 32397 +14
==========================================
- Hits 18401 18392 -9
- Misses 13982 14005 +23 |
On a slightly unrelated note, looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI changes look fine. So, approving this preemptively but we should wait for a review from Aaron too.
Can I ask you to open a ticket with the context that you have in your working memory so that we don't lose it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall this is fine, given it only applies to the cleanup script.
Description
zizmor CI checks are failing because the cleanup action does not have a version/tag/branch pinned to it. This PR tags the action with
@main
.EDIT: That didn't work so as @Rajil1213 suggested, I've just commented the
cleanup
actions with# zizmor: ignore[unpinned-uses]
.Type of Change
Notes to Reviewers
Checklist
Related Issues