Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Ignore unpinned-uses to github cleanup actions #608

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

bewakes
Copy link
Contributor

@bewakes bewakes commented Jan 13, 2025

Description

zizmor CI checks are failing because the cleanup action does not have a version/tag/branch pinned to it. This PR tags the action with @main.

EDIT: That didn't work so as @Rajil1213 suggested, I've just commented the cleanup actions with # zizmor: ignore[unpinned-uses].

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@bewakes bewakes requested a review from a team as a code owner January 13, 2025 06:34
@bewakes bewakes marked this pull request as draft January 13, 2025 06:35
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Commit: c651589

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 7,239,474
EL_BLOCK 100,495
CL_BLOCK 55,340
L1_BATCH 12,460,065
L2_BATCH 5,448
CHECKPOINT 15,322

@Rajil1213
Copy link
Contributor

I think the easiest solution is to just add # zizmor: ignore[unpinned-uses] against each line where the cleanup action is used. zizmor will soon support full auditing for composite actions via woodruffw/zizmor#350. And this audit is just a warning. So, it should be fine either way.

We could also open an issue/PR upstream though.

@bewakes bewakes marked this pull request as ready for review January 13, 2025 08:55
@bewakes
Copy link
Contributor Author

bewakes commented Jan 13, 2025

As @Rajil1213 suggested, I've just commented the cleanup actions with # zizmor: ignore[unpinned-uses]. I haven't done anything about the upstream Issue/PR though.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.77%. Comparing base (cb020cb) to head (b461192).
Report is 2 commits behind head on main.

@@            Coverage Diff             @@
##             main     #608      +/-   ##
==========================================
- Coverage   56.82%   56.77%   -0.06%     
==========================================
  Files         308      308              
  Lines       32383    32397      +14     
==========================================
- Hits        18401    18392       -9     
- Misses      13982    14005      +23     

see 3 files with indirect coverage changes

@Rajil1213
Copy link
Contributor

On a slightly unrelated note, looks like uvx has been deprecated. We should consider moving to uvenv as recommended.

Copy link
Contributor

@Rajil1213 Rajil1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI changes look fine. So, approving this preemptively but we should wait for a review from Aaron too.

@storopoli
Copy link
Member

On a slightly unrelated note, looks like uvx has been deprecated. We should consider moving to uvenv as recommended.

Can I ask you to open a ticket with the context that you have in your working memory so that we don't lose it?

@bewakes bewakes changed the title CI: Pin cleanup action to main CI: Ignore unpinned-uses to github cleanup actions Jan 13, 2025
Copy link
Contributor

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall this is fine, given it only applies to the cleanup script.

@storopoli storopoli added this pull request to the merge queue Jan 13, 2025
Merged via the queue into main with commit 0864d5f Jan 13, 2025
20 checks passed
@storopoli storopoli deleted the ci/pin-cleanup-action branch January 13, 2025 16:23
OlegBayrak added a commit to OlegBayrak/strata_test that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants