Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse TxFilterConfig in L1-Scan Guest code #611

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Jan 14, 2025

Description

Instead of computing a new TxFilterConfig for each L1 block scan, reuse the same TxFilterConfig for the entire batch.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.78%. Comparing base (22f0e74) to head (0718a38).
Report is 9 commits behind head on main.

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   56.82%   56.78%   -0.05%     
==========================================
  Files         308      308              
  Lines       32367    32404      +37     
==========================================
+ Hits        18394    18402       +8     
- Misses      13973    14002      +29     
Files with missing lines Coverage Δ
crates/proof-impl/btc-blockspace/src/filter.rs 50.00% <100.00%> (-3.85%) ⬇️
crates/proof-impl/btc-blockspace/src/logic.rs 97.43% <100.00%> (+0.13%) ⬆️
crates/proof-impl/btc-blockspace/src/scan.rs 100.00% <100.00%> (ø)
crates/proof-impl/l1-batch/src/logic.rs 97.50% <100.00%> (+0.27%) ⬆️

... and 16 files with indirect coverage changes

@MdTeach MdTeach changed the title reuse TxFilterConfig in all the l1 batch Reuse TxFilterConfig in L1-Scan Guest code Jan 14, 2025
@MdTeach MdTeach requested a review from prajwolrg January 14, 2025 15:55
Copy link
Contributor

Commit: 477a44d

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 7,239,605
EL_BLOCK 100,495
CL_BLOCK 55,340
L1_BATCH 7,268,989
L2_BATCH 5,448
CHECKPOINT 15,322

@MdTeach MdTeach marked this pull request as ready for review January 14, 2025 16:14
@MdTeach MdTeach requested review from a team as code owners January 14, 2025 16:14
@prajwolrg prajwolrg added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit 89578af Jan 15, 2025
18 checks passed
@prajwolrg prajwolrg deleted the feat/migrate-txfilter-l1-batch branch January 15, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants