Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] fix: reth rpc should provide results for pending block related queries #624

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

sapinb
Copy link
Contributor

@sapinb sapinb commented Jan 20, 2025

Description

Fixes issues with reth rpc failing to provide responses at "pending" block.

Related: #623

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ddf59e3

backporting to 0.1.0

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.77%. Comparing base (a14d926) to head (ddf59e3).
Report is 36 commits behind head on releases/0.1.0.

@@                Coverage Diff                 @@
##           releases/0.1.0     #624      +/-   ##
==================================================
- Coverage           57.16%   56.77%   -0.40%     
==================================================
  Files                 256      263       +7     
  Lines               27048    28104    +1056     
==================================================
+ Hits                15462    15956     +494     
- Misses              11586    12148     +562     

see 31 files with indirect coverage changes

@sapinb sapinb merged commit b4ba53b into releases/0.1.0 Jan 21, 2025
16 of 17 checks passed
@sapinb sapinb deleted the STR-923-fix-pending-block-rpc-release branch January 21, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants