Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure hosts for application #1483

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Configure hosts for application #1483

merged 1 commit into from
Oct 10, 2024

Conversation

brucebolt
Copy link
Member

@brucebolt brucebolt commented Oct 8, 2024

Note: the healthcheck endpoints are requested by IP, not domain, so we need to specifically exclude them from the protection.

Trello card

Note: the healthcheck endpoints are requested by IP, not domain, so we
need to specifically exclude them from the protection.
@ChrisBAshton ChrisBAshton merged commit 38403ea into main Oct 10, 2024
11 checks passed
@ChrisBAshton ChrisBAshton deleted the add-hosts branch October 10, 2024 13:51
@brucebolt
Copy link
Member Author

I've realised this allows domains like app-name.dodgygov.uk. The regex will need to be updated to app-name\..*\.gov.uk$.

ChrisBAshton added a commit to alphagov/whitehall that referenced this pull request Oct 18, 2024
ChrisBAshton added a commit to alphagov/travel-advice-publisher that referenced this pull request Oct 18, 2024
ChrisBAshton added a commit to alphagov/specialist-publisher that referenced this pull request Oct 18, 2024
ChrisBAshton added a commit to alphagov/short-url-manager that referenced this pull request Oct 18, 2024
ChrisBAshton added a commit to alphagov/service-manual-publisher that referenced this pull request Oct 18, 2024
ChrisBAshton added a commit to alphagov/manuals-publisher that referenced this pull request Oct 18, 2024
ChrisBAshton added a commit to alphagov/maslow that referenced this pull request Oct 18, 2024
ChrisBAshton added a commit to alphagov/content-publisher that referenced this pull request Oct 18, 2024
ChrisBAshton added a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants