-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use type=module for application.js #1924
Conversation
002a101
to
d577791
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look to me 👍
The JS error in the browser relates to the closest polyfill, further info here - alphagov/smart-answers#6846 (review)
I'm happy to give this another look and approve when the new version of the gem is released and included in this PR as this should then resolve the issue.
2089a30
to
ddbc179
Compare
d23267a
to
2377c99
Compare
What / Why
static
first before this is merged.es6-components.js
again as a separate task unless you disagree with thisgovuk_publishing_components
branch linked above. If you test without, this app'sapplication.js
seems to crash.type=module
as well.