-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use type=module for application.js #3409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
changed the title
Type module changes
[DO NOT MERGE] Use type=module for application.js
Jul 23, 2024
AshGDS
added
the
do-not-merge
Indicates that a PR should not be merged into master / release branches
label
Jul 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes look to me.
The failing tests will likely be caused by the JS error relating to the closest polyfill, further info here - alphagov/smart-answers#6846 (review)
I'm happy to give this another look when the new version of the gem is released and included in this PR
AshGDS
force-pushed
the
type-module-changes
branch
from
August 15, 2024 15:28
e8f72c3
to
fe36722
Compare
andysellick
force-pushed
the
type-module-changes
branch
from
August 15, 2024 15:54
fe36722
to
1a77193
Compare
AshGDS
force-pushed
the
type-module-changes
branch
from
August 15, 2024 16:01
1a77193
to
9cc9d21
Compare
MartinJJones
approved these changes
Aug 15, 2024
AshGDS
changed the title
[DO NOT MERGE] Use type=module for application.js
Use type=module for application.js
Aug 15, 2024
AshGDS
removed
the
do-not-merge
Indicates that a PR should not be merged into master / release branches
label
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
static
first before this is merged.es6-components.js
again as a separate task unless you disagree with thisgovuk_publishing_components
branch linked above. If you test without, this app'sapplication.js
seems to crash.type=module
as well.