Address Shellcheck errors (from Lint check)

alphagov · Jan 20, 2025 · 4558248 · 4558248
1 parent 2db2315
commit 4558248
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -28,13 +28,12 @@ jobs:
       - name: Helm template
         run: |
           mkdir helm-dist
-          for c in $(ls charts)
-          do
-            helm template "${c}" "charts/${c}" --output-dir helm-dist
+          for _chart in charts/*; do
+            helm template "$(basename "$_chart")" "$_chart" --output-dir helm-dist
           done
 
       - name: Read Kubernetes version from /kubernetes_version
-        run: "grep KUBERNETES_VERSION kubernetes_version >> $GITHUB_ENV"
+        run: grep KUBERNETES_VERSION kubernetes_version >> "$GITHUB_ENV"
 
       - name: kubeconform
         uses: docker://ghcr.io/yannh/kubeconform:latest-alpine