This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Deprecate the plugin #10
Merged
romaricpascal
merged 12 commits into
alphagov:main
from
x-govuk:mark-plugin-as-pre-govuk-v5
Dec 18, 2023
Merged
Deprecate the plugin #10
romaricpascal
merged 12 commits into
alphagov:main
from
x-govuk:mark-plugin-as-pre-govuk-v5
Dec 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This plugin shouldn't be used beyond v5 of `govuk-frontend`, as that will contain the Task list component directly.
frankieroberto
commented
Sep 25, 2023
3 tasks
@colinrotherham @stevenjmesser this can be merged and released now. It deprecates the plugin and marks it as non-compatible with govuk-frontend v5. Once merged and released the repo can probably be archived too? |
colinrotherham
approved these changes
Dec 14, 2023
If you're happy to give this a 2nd approval @querkmachine we can figure out how to publish it Shall we save time and do a version bump (see example) in this PR? |
querkmachine
approved these changes
Dec 15, 2023
I've created https://github.com/alphagov/design-system-team-internal/issues/851 so we can archive the repo. I'm not 100% sure we have the full access to do it but we can find out and ping whoever needs to do it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecates the plugin, by making it clear that it is no longer needed once version 5+ of
govuk-frontend
has been released.See also:
This shouldn't be merged until v5 of
govuk-frontend
has been released, and then the Prototype Kit updated.