Merge pull request #2458 from alphagov/fix-redirect

Section Redirects should be publishing the redirect afterwards

app/adapters/publishing/redirect_adapter.rb

@@ -2,8 +2,9 @@
 
 class Publishing::RedirectAdapter
   def self.redirect_section(section, to:)
+    redirect_content_id = SecureRandom.uuid
     Services.publishing_api.put_content(
-      SecureRandom.uuid,
+      redirect_content_id,
       document_type: "redirect",
       schema_name: "redirect",
       publishing_app: GdsApiConstants::PublishingApi::PUBLISHING_APP,
@@ -15,6 +16,8 @@ def self.redirect_section(section, to:)
           destination: to,
         },
       ],
+      update_type: "major",
     )
+    Services.publishing_api.publish(redirect_content_id)
   end
 end

spec/adapters/publishing/redirect_adapter_spec.rb

@@ -22,7 +22,9 @@
             destination: "/new-location",
           },
         ],
+        update_type: "major",
       )
+      expect(Services.publishing_api).to receive(:publish).with(redirect_content_id)
       Publishing::RedirectAdapter.redirect_section(section, to: "/new-location")
     end
 
@@ -31,6 +33,7 @@
         redirect_content_id,
         be_valid_against_publisher_schema("redirect"),
       )
+      expect(Services.publishing_api).to receive(:publish).with(redirect_content_id)
       Publishing::RedirectAdapter.redirect_section(section, to: "/new-location")
     end
 
@@ -49,7 +52,9 @@
             destination: "/new-location",
           },
         ],
+        update_type: "major",
       )
+      expect(Services.publishing_api).to receive(:publish).with(redirect_content_id)
       Publishing::RedirectAdapter.redirect_section(manual, to: "/new-location")
     end
   end

spec/lib/tasks/withdraw_and_redirect_section_rake_spec.rb

@@ -34,7 +34,9 @@
             destination: "/guidance/parent_path",
           },
         ],
+        update_type: "major",
       )
+      assert_publishing_api_publish("some-random-uuid")
     end
   end
 end