Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new ADR that documents our decision to move to Postgres #2128

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

andy-collon
Copy link
Contributor

https://trello.com/c/S1BbvoQN/262-document-our-decision-to-replatform-our-db-to-postgresql

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

Copy link
Contributor

@mtaylorgds mtaylorgds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but worth other devs having a look first too.

Copy link
Contributor

@richardTowers richardTowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for this!

Happy to approve this as an initial statement of intent. We'll eventually need a bit more detail on how we're going to structure things in the new postgres world, but I imagine we'll want to do some spikes to inform those decisions before we write too much in an ADR.

We've got a few different approaches to relational database schemas for publishing apps:

... and I guess we've got an option here to try to be consistent with one of those, or to introduce another model.

I think it's totally fine if we end up making the call to build a schema that's very similar to the structure in mongo at the moment - e.g. if that makes migration easier, or reduces the changes we have to make to the code so the project gets done sooner. Still, if we think it's doable without disrupting the project too much, it would be good to aim for a schema we're happy with. Personally, I like content-publisher and publishing-api, because they've abstracted the individual content types away from the database schema - they just have documents and editions etc.

... anyway, thanks for this! ✅

@andy-collon andy-collon merged commit aaca838 into main Apr 8, 2024
16 checks passed
@andy-collon andy-collon deleted the adr-009-mongo-to-postgres branch April 8, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants