Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove marriage abroad code #6898

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Remove marriage abroad code #6898

merged 6 commits into from
Oct 4, 2024

Conversation

ellohez
Copy link
Contributor

@ellohez ellohez commented Sep 30, 2024

This is part of the Clean up 'Get married abroad' smart answer (post-retirement) work
The code relating to Get Married Abroad can now safely be deleted now that the Smart Answer has successfully been migrated to the new version now hosted by Mainstream Publisher.

This includes

  • Flow class files (app/flows/marriage_abroad...)
  • ERB templates Directory (app/flows/marriage_abroad...)
  • YAML files (config/smart_answers/marriage_abroad... and config/smart_answers/rates/marriage_abroad...)
  • Calculators, data queries and other (lib/smart_answer/calculators/marriage_abroad
  • Tests
  • Docs

@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6898 September 30, 2024 10:28 Inactive
- Checked for usages before deleting.
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6898 September 30, 2024 16:15 Inactive
@ellohez ellohez marked this pull request as ready for review September 30, 2024 16:36
Copy link
Contributor

@Tetrino Tetrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mtaylorgds
Copy link
Contributor

Might be worth updating the docs/debugging/visualising-flows.md file to use a different example from marriage abroad, so that the example CLI commands can be copy and pasted and "just work".

@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6898 October 2, 2024 11:10 Inactive
@ellohez
Copy link
Contributor Author

ellohez commented Oct 2, 2024

Might be worth updating the docs/debugging/visualising-flows.md file to use a different example from marriage abroad, so that the example CLI commands can be copy and pasted and "just work".

I have updated this so the example is now check-uk-visa and I ran the commands so should all be fine.

@ellohez ellohez closed this Oct 2, 2024
@ellohez ellohez reopened this Oct 2, 2024
@govuk-ci govuk-ci temporarily deployed to smart-answers-pr-6898 October 2, 2024 11:13 Inactive
@ellohez ellohez merged commit 5b0d76f into main Oct 4, 2024
22 checks passed
@ellohez ellohez deleted the remove-marriage-abroad-code branch October 4, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants