-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content modelling/627 filter by type and lead organisation #9557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
force-pushed
the
content-modelling/627-filter-by-type
branch
from
October 25, 2024 09:53
2895dae
to
6f61f7c
Compare
Harriethw
force-pushed
the
content-modelling/626-search-by-keyword
branch
from
October 25, 2024 09:55
2cb9d61
to
29747e6
Compare
Harriethw
force-pushed
the
content-modelling/627-filter-by-type
branch
4 times, most recently
from
October 25, 2024 15:51
17b25d3
to
6354ef7
Compare
Harriethw
changed the title
Content modelling/627 filter by type
Content modelling/627 filter by type and lead organisation
Oct 25, 2024
Harriethw
force-pushed
the
content-modelling/626-search-by-keyword
branch
from
October 25, 2024 15:53
29747e6
to
ecd39ae
Compare
Harriethw
force-pushed
the
content-modelling/627-filter-by-type
branch
from
October 25, 2024 15:55
6354ef7
to
e5fa334
Compare
Base automatically changed from
content-modelling/626-search-by-keyword
to
main
October 28, 2024 09:29
this adds hardcoded checkboxes to filter Content Blocks by block type. We will shortly generate these checkboxes from the list of valid schemas.
this will enable us to do more complicated functions like generating checkboxes for block types.
Harriethw
force-pushed
the
content-modelling/627-filter-by-type
branch
from
October 28, 2024 09:30
e5fa334
to
66a7a99
Compare
pezholio
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -0,0 +1,18 @@ | |||
class ContentBlockManager::ContentBlock::Document::Index::FilterOptionsComponent < ViewComponent::Base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like all this in a component 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged #9549 then this can be done.Adds filtering by block type and lead organisation.
Follow these steps if you are doing a Rails upgrade.