Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content modelling/627 filter by type and lead organisation #9557

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

Harriethw
Copy link
Contributor

@Harriethw Harriethw commented Oct 24, 2024

Once this PR is merged #9549 then this can be done.

Adds filtering by block type and lead organisation.

Screenshot 2024-10-25 at 16 52 11


⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@Harriethw Harriethw force-pushed the content-modelling/627-filter-by-type branch from 2895dae to 6f61f7c Compare October 25, 2024 09:53
@Harriethw Harriethw force-pushed the content-modelling/626-search-by-keyword branch from 2cb9d61 to 29747e6 Compare October 25, 2024 09:55
@Harriethw Harriethw force-pushed the content-modelling/627-filter-by-type branch 4 times, most recently from 17b25d3 to 6354ef7 Compare October 25, 2024 15:51
@Harriethw Harriethw changed the title Content modelling/627 filter by type Content modelling/627 filter by type and lead organisation Oct 25, 2024
@Harriethw Harriethw force-pushed the content-modelling/626-search-by-keyword branch from 29747e6 to ecd39ae Compare October 25, 2024 15:53
@Harriethw Harriethw force-pushed the content-modelling/627-filter-by-type branch from 6354ef7 to e5fa334 Compare October 25, 2024 15:55
Base automatically changed from content-modelling/626-search-by-keyword to main October 28, 2024 09:29
@Harriethw Harriethw marked this pull request as ready for review October 28, 2024 09:29
this adds hardcoded checkboxes to filter Content
Blocks by block type. We will shortly generate
these checkboxes from the list of valid schemas.
this will enable us to do more complicated
functions like generating checkboxes for block
types.
@Harriethw Harriethw force-pushed the content-modelling/627-filter-by-type branch from e5fa334 to 66a7a99 Compare October 28, 2024 09:30
Copy link
Contributor

@pezholio pezholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -0,0 +1,18 @@
class ContentBlockManager::ContentBlock::Document::Index::FilterOptionsComponent < ViewComponent::Base
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like all this in a component 👍

@Harriethw Harriethw merged commit db797c1 into main Oct 28, 2024
19 checks passed
@Harriethw Harriethw deleted the content-modelling/627-filter-by-type branch October 28, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants