testing/pacparser: new aport #125
Conversation
A library to parse proxy auto-config (PAC) files http://pacparser.manugarg.com
aaronhurt
force-pushed
the
testing/pacparser
branch
from
e0b4c9f to
9db8f11
Compare
|
|
||
| package() { | ||
| cd "$builddir" | ||
| make -C src install DESTDIR=$pkgdir LIB_PREFIX=$pkgdir/usr/lib > /dev/null 2>&1 || return 1 |
There was a problem hiding this comment.
Why you’re redirecting stdout/stderr of make to /dev/null?
There was a problem hiding this comment.
No real reason, it's just quite a bit of output building all the components.
There was a problem hiding this comment.
It's always better to have a lot of output than none. How would you know what's wrong if the package fail to build, when you throw away even error messages?
There was a problem hiding this comment.
I added it after the build was working. I was looking at it more as debug output. I took it off and Travis has rebuilt the package.
aaronhurt
force-pushed
the
testing/pacparser
branch
from
d0878df to
79676f1
Compare
| @@ -0,0 +1,17 @@ | |||
| --- src/spidermonkey/Makefile.orig | |||
There was a problem hiding this comment.
Please add comment to the patch file explaining why is this patch needed.
jirutka
added
the
S-changes-requested
aaronhurt
force-pushed
the
testing/pacparser
branch
from
b0fcedf to
7bfeb01
Compare
jirutka
added
reviewed
S-ready
|
Merged in 4e051e1, thanks! It failed to compile because of manugarg/pacparser#27, so I’ve forced |
|
Great, thank you sir. |
|
It fails not just on armhf, but also x86, so it’s currently built only for x86_64. I’ve reported it to upstream: manugarg/pacparser#77. |
A library to parse proxy auto-config (PAC) files
http://pacparser.manugarg.com