feat: Changed the installation method of flutterfire_cli in the post-clone script for Xcode Cloud
#492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-clone script for Xcode Cloud
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
=======================================
Coverage 23.75% 23.75%
=======================================
Files 13 13
Lines 160 160
=======================================
Hits 38 38
Misses 122 122 Continue to review full report in Codecov by Sentry.
|
naipaka
commented
Sep 3, 2024
| @@ -33,8 +33,8 @@ brew install cocoapods | |||
| cd ios && pod install # run `pod install` in the `ios` directory. | |||
|
|
|||
| # The flutterfire command is used in Xcode Build Phases and must be installed in advance. | |||
| curl -sL https://firebase.tools | bash | |||
There was a problem hiding this comment.
It appears that flutterfire_cli can be installed with dart pub without this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issues
🙌 What's Done
flutterfire_cliin the post-clone script for Xcode Cloud✍️ What's Not Done
🖼️ Image Differences
🤼 Desired Review Method
Note
It is possible that a reviewer's will may cause a method to be implemented that is not selected.
📝 Additional Notes
Reference: https://zenn.dev/link/comments/bc613295c20ed0
Pre-launch Checklist