Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix network image exception for macOS #497

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: Fix network image exception for macOS #497

merged 1 commit into from
Sep 25, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Sep 22, 2024 •
edited
Loading

🙌 What's Done

  • Fix network image exception for macOS

✍️ What's Not Done

🖼️ Image Differences

After

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@riscait riscait marked this pull request as ready for review September 22, 2024 18:10
@riscait riscait requested a review from a team as a code owner September 22, 2024 18:10
@riscait riscait requested review from k-nkmr and removed request for a team September 22, 2024 18:10
k-nkmr
k-nkmr approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@k-nkmr k-nkmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riscait riscait force-pushed the fix-network-image-exception-for-macos branch from 55ec2d3 to cff281a Compare September 25, 2024 00:39
@riscait riscait enabled auto-merge (squash) September 25, 2024 00:39
@riscait riscait merged commit 8f0d427 into main Sep 25, 2024
6 checks passed
@riscait riscait deleted the fix-network-image-exception-for-macos branch September 25, 2024 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-nkmr k-nkmr k-nkmr approved these changes

Assignees

@riscait riscait

Labels
flutter_app macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riscait @k-nkmr