Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Widget Catalog with widgetbook #498

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: Add Widget Catalog with widgetbook #498

merged 1 commit into from
Sep 24, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Sep 24, 2024

🙌 What's Done

  • Added Widget Catalog with widgetbook package for macOS and Web
    • flutter create packages/widget_catalog --platforms=macos,web

✍️ What's Not Done

  • Add a widget to WidgetCatalog (this time add a few for trial)

🖼️ Image Differences

macOS Web
image image

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@github-actions github-actions bot added documentation Improvements or additions to documentation macos web labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (cb2ee24) to head (0855cff).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2ee24...0855cff. Read the comment docs.

@riscait riscait marked this pull request as ready for review September 24, 2024 05:04
@riscait riscait requested a review from a team as a code owner September 24, 2024 05:04
@riscait riscait requested review from naipaka and removed request for a team September 24, 2024 05:04
Copy link
Contributor

@naipaka naipaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tried running it on Flutter Web! It seems convenient. 👏

As for deployment options, there are choices like GitHub Pages (is it a good match for public repositories?) and Widgetbook Cloud (not yet released?). ✍️

@riscait
Copy link
Member Author

riscait commented Sep 24, 2024

As for deployment options, there are choices like GitHub Pages (is it a good match for public repositories?) and Widgetbook Cloud (not yet released?). ✍️

Thanks! I would certainly like to publish the web automatically!
Issue created👍
#499

@riscait riscait merged commit c948c50 into main Sep 24, 2024
8 checks passed
@riscait riscait deleted the widget-catalog branch September 24, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation macos web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants