Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use latest version altive_lints with custom_lint for all packages #503

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

riscait
Copy link
Member

@riscait riscait commented Oct 9, 2024

🙌 What's Done

  • Update altive_lints to latest version
  • Enable custom_lint rules for all packages

Widget Catalog

  • AppleAuthButton
  • GoogleAuthButton
Google Apple
CleanShot 2024-10-09 at 16 41 11@2x image
image image

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.75%. Comparing base (46784ff) to head (ca8642a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #503   +/-   ##
=======================================
  Coverage   23.75%   23.75%           
=======================================
  Files          13       13           
  Lines         160      160           
=======================================
  Hits           38       38           
  Misses        122      122           
Files with missing lines Coverage Δ
...ate_requester/entities/requested_version_info.dart 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46784ff...ca8642a. Read the comment docs.

@riscait riscait marked this pull request as ready for review October 9, 2024 07:31
@riscait riscait requested a review from a team as a code owner October 9, 2024 07:31
@riscait riscait requested review from k-nkmr and removed request for a team October 9, 2024 07:31
Copy link
Contributor

@k-nkmr k-nkmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riscait riscait merged commit 566abf1 into main Oct 10, 2024
9 checks passed
@riscait riscait deleted the use-latest-altive_lints-with-custom_lint branch October 10, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants