Merge pull request #336 from altmp/feature/js-timers-leak

Fix js-module timers leak
altmp · Dec 16, 2024 · 7b6b4ae · 7b6b4ae
2 parents 5d9f68b + e8744d8
commit 7b6b4ae
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/shared/V8ResourceImpl.cpp b/shared/V8ResourceImpl.cpp
@@ -77,7 +77,16 @@ void V8ResourceImpl::OnTick()
     for(auto& nextTickCb : nextTickCallbacks) nextTickCb();
     nextTickCallbacks.clear();
 
-    for(auto& id : oldTimers) timers.erase(id);
+    for(auto& id : oldTimers)
+    {
+        auto it = timers.find(id);
+        if(it == timers.end())
+            continue;
+
+        auto timer = it->second;
+        timers.erase(it);
+        delete timer;
+    }
 
     oldTimers.clear();