chore(client): increase .all property performance by not creating a c…

…opy on an already frozen instance
altmp · Mar 29, 2024 · e30f4e3 · e30f4e3
1 parent 1714dcb
commit e30f4e3
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/client/src/bindings/AudioOutput.cpp b/client/src/bindings/AudioOutput.cpp
@@ -19,7 +19,7 @@ static void AllAudioOutputGetter(v8::Local<v8::String> name, const v8::PropertyC
 {
     V8_GET_ISOLATE_CONTEXT_RESOURCE();
 
-    V8_RETURN(resource->GetAllAudioOutputs()->Clone());
+    V8_RETURN(resource->GetAllAudioOutputs());
 }
 
 static void AudioOutputCountGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)

diff --git a/client/src/bindings/Player.cpp b/client/src/bindings/Player.cpp
@@ -39,7 +39,7 @@ static void AllGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo
 {
     V8_GET_ISOLATE_CONTEXT_RESOURCE();
 
-    V8_RETURN(resource->GetAllPlayers()->Clone());
+    V8_RETURN(resource->GetAllPlayers());
 }
 
 static void CountGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)

diff --git a/client/src/bindings/Vehicle.cpp b/client/src/bindings/Vehicle.cpp
@@ -66,7 +66,7 @@ static void AllGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo
 {
     V8_GET_ISOLATE_CONTEXT_RESOURCE();
 
-    V8_RETURN(resource->GetAllVehicles()->Clone());
+    V8_RETURN(resource->GetAllVehicles());
 }
 
 static void CountGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)

diff --git a/shared/bindings/Blip.cpp b/shared/bindings/Blip.cpp
@@ -199,7 +199,7 @@ static void AllGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo
 {
     V8_GET_ISOLATE_CONTEXT_RESOURCE();
 
-    V8_RETURN(resource->GetAllBlips()->Clone());
+    V8_RETURN(resource->GetAllBlips());
 }
 
 static void CountGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)

diff --git a/shared/bindings/ColShape.cpp b/shared/bindings/ColShape.cpp
@@ -36,7 +36,7 @@ static void AllGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo
 {
     V8_GET_ISOLATE_CONTEXT_RESOURCE();
 
-    V8_RETURN(resource->GetAllColshapes()->Clone());
+    V8_RETURN(resource->GetAllColshapes());
 }
 
 static void StaticGetByID(const v8::FunctionCallbackInfo<v8::Value>& info)

diff --git a/shared/bindings/Marker.cpp b/shared/bindings/Marker.cpp
@@ -33,7 +33,7 @@ static void AllGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo
 {
     V8_GET_ISOLATE_CONTEXT_RESOURCE();
 
-    V8_RETURN(resource->GetAllMarkers()->Clone());
+    V8_RETURN(resource->GetAllMarkers());
 }
 
 static void TypeGetter(v8::Local<v8::String>, const v8::PropertyCallbackInfo<v8::Value>& info)