Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTV-393 v8::External::New can't be called with value == nullptr #325

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

kin4stat-alt
Copy link
Contributor

@kin4stat-alt kin4stat-alt commented Sep 11, 2024

From v8 sources:

Local<External> v8::External::New(Isolate* isolate, void* value) {
  // Nullptr is not allowed here because serialization/deserialization of
  // nullptr external api references is not possible as nullptr is used as an
  // external_references table terminator, see v8::SnapshotCreator()
  // constructors.
  DCHECK_NOT_NULL(value);

this causes undefined behaviour and asserts in debug build and does not allow to continue code execution

- V8 doesn't allow to call v8::External::New with value == nullptr
@xLuxy xLuxy merged commit 22285f0 into dev Sep 24, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants