Unable to create clippy annotations! Reason: HttpError: request to https://api.github.com/repos/alvr-org/ALVR/check-runs failed, reason: connect ETIMEDOUT 140.82.112.5:443

check-format

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

check-format

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

check-format

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

check-format

function `notice` is never used: alvr/dashboard/src/dashboard/components/settings_controls/notice.rs#L8

warning: function `notice` is never used --> alvr/dashboard/src/dashboard/components/settings_controls/notice.rs:8:8 | 8 | pub fn notice(ui: &mut Ui, text: &str) { | ^^^^^^ | = note: `#[warn(dead_code)]` on by default

this expression creates a reference which is immediately dereferenced by the compiler: alvr/client_openxr/src/stream.rs#L440

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr/client_openxr/src/stream.rs:440:50 | 440 | let Some(xr_now) = crate::xr_runtime_now(&xr_session.instance()) else { | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `xr_session.instance()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: alvr/client_openxr/src/stream.rs#L365

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr/client_openxr/src/stream.rs:365:57 | 365 | if let Some(xr_now) = crate::xr_runtime_now(&self.xr_session.instance()) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.xr_session.instance()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

transmute used without annotations: alvr/client_openxr/src/passthrough.rs#L41

warning: transmute used without annotations --> alvr/client_openxr/src/passthrough.rs:41:27 | 41 | unsafe { mem::transmute(handle.layer()) } | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&openxr::openxr_sys::CompositionLayerPassthroughHTC, &openxr::CompositionLayerBase<'_, openxr::OpenGlEs>>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations

transmute used without annotations: alvr/client_openxr/src/passthrough.rs#L39

warning: transmute used without annotations --> alvr/client_openxr/src/passthrough.rs:39:27 | 39 | unsafe { mem::transmute(handle.layer()) } | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&openxr::openxr_sys::CompositionLayerPassthroughFB, &openxr::CompositionLayerBase<'_, openxr::OpenGlEs>>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations = note: `#[warn(clippy::missing_transmute_annotations)]` on by default

field `platform` is never read: alvr/client_openxr/src/interaction.rs#L103

warning: field `platform` is never read --> alvr/client_openxr/src/interaction.rs:103:5 | 101 | pub struct InteractionContext { | ------------------ field in this struct 102 | xr_session: xr::Session<xr::OpenGlEs>, 103 | platform: Platform, | ^^^^^^^^

fields `aim_action` and `aim_space` are never read: alvr/client_openxr/src/interaction.rs#L50

warning: fields `aim_action` and `aim_space` are never read --> alvr/client_openxr/src/interaction.rs:50:9 | 46 | pub struct HandInteraction { | --------------- fields in this struct ... 50 | pub aim_action: xr::Action<xr::Posef>, | ^^^^^^^^^^ 51 | pub aim_space: xr::Space, | ^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

variable does not need to be mutable: alvr/client_openxr/src/lib.rs#L192

warning: variable does not need to be mutable --> alvr/client_openxr/src/lib.rs:192:9 | 192 | let mut last_lobby_message = String::new(); | ----^^^^^^^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

unused variable: `xr_frame_stream`: alvr/client_openxr/src/lib.rs#L204

warning: unused variable: `xr_frame_stream` --> alvr/client_openxr/src/lib.rs:204:51 | 204 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe { | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`

unused variable: `xr_frame_waiter`: alvr/client_openxr/src/lib.rs#L204

warning: unused variable: `xr_frame_waiter` --> alvr/client_openxr/src/lib.rs:204:30 | 204 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe { | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`

unused variable: `xr_session`: alvr/client_openxr/src/lib.rs#L204

warning: unused variable: `xr_session` --> alvr/client_openxr/src/lib.rs:204:14 | 204 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe { | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`

unused variable: `last_lobby_message`: alvr/client_openxr/src/lib.rs#L192

warning: unused variable: `last_lobby_message` --> alvr/client_openxr/src/lib.rs:192:13 | 192 | let mut last_lobby_message = String::new(); | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message` | = note: `#[warn(unused_variables)]` on by default

unreachable definition: alvr/client_openxr/src/lib.rs#L210

warning: unreachable definition --> alvr/client_openxr/src/lib.rs:210:13 | 206 | .create_session(xr_system, &graphics::session_create_info(&graphics_context)) | ------------------------------------------------ any code following this expression is unreachable ... 210 | let views_config = xr_instance | ^^^^^^^^^^^^ unreachable definition | note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited --> alvr/client_openxr/src/lib.rs:206:45 | 206 | .create_session(xr_system, &graphics::session_create_info(&graphics_context)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(unreachable_code)]` on by default

using `clone` on type `ViewParams` which implements the `Copy` trait: alvr/client_mock/src/main.rs#L158

warning: using `clone` on type `ViewParams` which implements the `Copy` trait --> alvr/client_mock/src/main.rs:158:31 | 158 | context.send_view_params([views_params.clone(), views_params]); | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `views_params` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

this `.filter_map` can be written more simply using `.map`: alvr/server_core/src/tracking/mod.rs#L526

warning: this `.filter_map` can be written more simply using `.map` --> alvr/server_core/src/tracking/mod.rs:526:38 | 526 | let device_motions = device_motion_keys | ______________________________________^ 527 | | .iter() 528 | | .filter_map(move |id| { 529 | | Some(( ... | 534 | | )) 535 | | }) | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map

this `.filter_map` can be written more simply using `.map`: alvr/server_core/src/tracking/mod.rs#L497

warning: this `.filter_map` can be written more simply using `.map` --> alvr/server_core/src/tracking/mod.rs:497:38 | 497 | let device_motions = device_motion_keys | ______________________________________^ 498 | | .iter() 499 | | .filter_map(move |id| { 500 | | Some(( ... | 505 | | )) 506 | | }) | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map = note: `#[warn(clippy::unnecessary_filter_map)]` on by default

float has excessive precision: alvr/server_core/src/tracking/vmc.rs#L67

warning: float has excessive precision --> alvr/server_core/src/tracking/vmc.rs:67:48 | 67 | Quat::from_xyzw(0.70228, -0.08246, 0.7071100, 0.00000), | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision help: consider changing the type or truncating it to | 67 | Quat::from_xyzw(0.70228, -0.08246, 0.707_11, 0.00000), | ~~~~~~~~

float has excessive precision: alvr/server_core/src/tracking/vmc.rs#L59

warning: float has excessive precision --> alvr/server_core/src/tracking/vmc.rs:59:58 | 59 | Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.7071100), | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision = note: `#[warn(clippy::excessive_precision)]` on by default help: consider changing the type or truncating it to | 59 | Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.707_11), | ~~~~~~~~

casting to the same type is unnecessary (`f32` -> `f32`): alvr/server_core/src/bitrate.rs#L133

warning: casting to the same type is unnecessary (`f32` -> `f32`) --> alvr/server_core/src/bitrate.rs:133:25 | 133 | self.packet_bytes_average.get_average() as f32, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.packet_bytes_average.get_average()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

returning the result of a `let` binding from a block: alvr/client_core/src/lib.rs#L364

warning: returning the result of a `let` binding from a block --> alvr/client_core/src/lib.rs:364:9 | 353 | / let view_params = [ 354 | | ViewParams { 355 | | pose: head_pose * view_params[0].pose, 356 | | fov: view_params[0].fov, ... | 361 | | }, 362 | | ]; | |__________- unnecessary `let` binding 363 | 364 | view_params | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 353 ~ 354 | 355 ~ [ 356 + ViewParams { 357 + pose: head_pose * view_params[0].pose, 358 + fov: view_params[0].fov, 359 + }, 360 + ViewParams { 361 + pose: head_pose * view_params[1].pose, 362 + fov: view_params[1].fov, 363 + }, 364 + ] |

very complex type used. Consider factoring parts into `type` definitions: alvr/client_core/src/lib.rs#L312

warning: very complex type used. Consider factoring parts into `type` definitions --> alvr/client_core/src/lib.rs:312:19 | 312 | callback: Box<dyn FnMut(Duration, &[u8]) -> bool + Send>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: alvr/client_core/src/connection.rs#L65

warning: very complex type used. Consider factoring parts into `type` definitions --> alvr/client_core/src/connection.rs:65:27 | 65 | pub decoder_callback: Mutex<Option<Box<dyn FnMut(Duration, &[u8]) -> bool + Send>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

variants `Float`, `Int32`, `Int64`, and `String` are never constructed: alvr/client_core/src/c_api.rs#L839

warning: variants `Float`, `Int32`, `Int64`, and `String` are never constructed --> alvr/client_core/src/c_api.rs:839:5 | 838 | pub enum AlvrMediacodecPropType { | ---------------------- variants in this enum 839 | Float, | ^^^^^ 840 | Int32, | ^^^^^ 841 | Int64, | ^^^^^ 842 | String, | ^^^^^^

field `codec` is never read: alvr/client_core/src/c_api.rs#L78

warning: field `codec` is never read --> alvr/client_core/src/c_api.rs:78:9 | 77 | DecoderConfig { | ------------- field in this variant 78 | codec: AlvrCodec, | ^^^^^

fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read: alvr/client_core/src/c_api.rs#L71

warning: fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read --> alvr/client_core/src/c_api.rs:71:9 | 70 | Haptics { | ------- fields in this variant 71 | device_id: u64, | ^^^^^^^^^ 72 | duration_s: f32, | ^^^^^^^^^^ 73 | frequency: f32, | ^^^^^^^^^ 74 | amplitude: f32, | ^^^^^^^^^

fields `view_width`, `view_height`, `refresh_rate_hint`, `encoding_gamma`, `enable_foveated_encoding`, and `enable_hdr` are never read: alvr/client_core/src/c_api.rs#L62

warning: fields `view_width`, `view_height`, `refresh_rate_hint`, `encoding_gamma`, `enable_foveated_encoding`, and `enable_hdr` are never read --> alvr/client_core/src/c_api.rs:62:9 | 61 | StreamingStarted { | ---------------- fields in this variant 62 | view_width: u32, | ^^^^^^^^^^ 63 | view_height: u32, | ^^^^^^^^^^^ 64 | refresh_rate_hint: f32, | ^^^^^^^^^^^^^^^^^ 65 | encoding_gamma: f32, | ^^^^^^^^^^^^^^ 66 | enable_foveated_encoding: bool, | ^^^^^^^^^^^^^^^^^^^^^^^^ 67 | enable_hdr: bool, | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

fields `remote` and `serial` are never read: alvr/adb/src/parse.rs#L126

warning: fields `remote` and `serial` are never read --> alvr/adb/src/parse.rs:126:9 | 124 | pub struct ForwardedPorts { | -------------- fields in this struct 125 | pub local: u16, 126 | pub remote: u16, | ^^^^^^ 127 | pub serial: String, | ^^^^^^ | = note: `ForwardedPorts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

fields `connection_state`, `device`, `model`, `product`, and `transport_type` are never read: alvr/adb/src/parse.rs#L75

warning: fields `connection_state`, `device`, `model`, `product`, and `transport_type` are never read --> alvr/adb/src/parse.rs:75:9 | 74 | pub struct Device { | ------ fields in this struct 75 | pub connection_state: Option<ConnectionState>, | ^^^^^^^^^^^^^^^^ 76 | pub device: Option<String>, | ^^^^^^ 77 | pub model: Option<String>, | ^^^^^ 78 | pub product: Option<String>, | ^^^^^^^ 79 | pub serial: Option<String>, 80 | pub transport_type: Option<TransportType>, | ^^^^^^^^^^^^^^ | = note: `Device` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

function `list_installed_packages` is never used: alvr/adb/src/commands.rs#L240

warning: function `list_installed_packages` is never used --> alvr/adb/src/commands.rs:240:8 | 240 | pub fn list_installed_packages(adb_path: &str, device_serial: &str) -> Result<HashSet<String>> { | ^^^^^^^^^^^^^^^^^^^^^^^

function `uninstall_package` is never used: alvr/adb/src/commands.rs#L229

warning: function `uninstall_package` is never used --> alvr/adb/src/commands.rs:229:8 | 229 | pub fn uninstall_package(adb_path: &str, device_serial: &str, application_id: &str) -> Result<()> { | ^^^^^^^^^^^^^^^^^

function `is_package_installed` is never used: alvr/adb/src/commands.rs#L215

warning: function `is_package_installed` is never used --> alvr/adb/src/commands.rs:215:8 | 215 | pub fn is_package_installed( | ^^^^^^^^^^^^^^^^^^^^

function `install_package` is never used: alvr/adb/src/commands.rs#L207

warning: function `install_package` is never used --> alvr/adb/src/commands.rs:207:8 | 207 | pub fn install_package(adb_path: &str, device_serial: &str, apk_path: &str) -> Result<()> { | ^^^^^^^^^^^^^^^

function `start_application` is never used: alvr/adb/src/commands.rs#L168

warning: function `start_application` is never used --> alvr/adb/src/commands.rs:168:8 | 168 | pub fn start_application(adb_path: &str, device_serial: &str, application_id: &str) -> Result<()> { | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

function `build_windows_installer` is never used: alvr/xtask/src/packaging.rs#L21

warning: function `build_windows_installer` is never used --> alvr/xtask/src/packaging.rs:21:4 | 21 | fn build_windows_installer() { | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

check-macos

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

check-macos

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

check-macos

The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

check-macos

tests

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

tests

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

tests

build-android

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions/setup-java@v2, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

build-android

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, actions/setup-java@v2, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

build-android

check-msrv-linux

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

check-msrv-linux

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

check-msrv-linux

function `notice` is never used: alvr\dashboard\src\dashboard\components\settings_controls\notice.rs#L8

warning: function `notice` is never used --> alvr\dashboard\src\dashboard\components\settings_controls\notice.rs:8:8 | 8 | pub fn notice(ui: &mut Ui, text: &str) { | ^^^^^^ | = note: `#[warn(dead_code)]` on by default

using `clone` on type `ViewParams` which implements the `Copy` trait: alvr\client_mock\src/main.rs#L158

warning: using `clone` on type `ViewParams` which implements the `Copy` trait --> alvr\client_mock\src/main.rs:158:31 | 158 | context.send_view_params([views_params.clone(), views_params]); | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `views_params` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

this expression creates a reference which is immediately dereferenced by the compiler: alvr\client_openxr\src\stream.rs#L440

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\client_openxr\src\stream.rs:440:50 | 440 | let Some(xr_now) = crate::xr_runtime_now(&xr_session.instance()) else { | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `xr_session.instance()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: alvr\client_openxr\src\stream.rs#L365

warning: this expression creates a reference which is immediately dereferenced by the compiler --> alvr\client_openxr\src\stream.rs:365:57 | 365 | if let Some(xr_now) = crate::xr_runtime_now(&self.xr_session.instance()) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.xr_session.instance()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

transmute used without annotations: alvr\client_openxr\src\passthrough.rs#L41

warning: transmute used without annotations --> alvr\client_openxr\src\passthrough.rs:41:27 | 41 | unsafe { mem::transmute(handle.layer()) } | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&openxr::openxr_sys::CompositionLayerPassthroughHTC, &openxr::CompositionLayerBase<'_, openxr::OpenGlEs>>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations

transmute used without annotations: alvr\client_openxr\src\passthrough.rs#L39

warning: transmute used without annotations --> alvr\client_openxr\src\passthrough.rs:39:27 | 39 | unsafe { mem::transmute(handle.layer()) } | ^^^^^^^^^ help: consider adding missing annotations: `transmute::<&openxr::openxr_sys::CompositionLayerPassthroughFB, &openxr::CompositionLayerBase<'_, openxr::OpenGlEs>>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations = note: `#[warn(clippy::missing_transmute_annotations)]` on by default

this `.filter_map` can be written more simply using `.map`: alvr\server_core\src\tracking\mod.rs#L526

warning: this `.filter_map` can be written more simply using `.map` --> alvr\server_core\src\tracking\mod.rs:526:38 | 526 | let device_motions = device_motion_keys | ______________________________________^ 527 | | .iter() 528 | | .filter_map(move |id| { 529 | | Some(( ... | 534 | | )) 535 | | }) | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map

this `.filter_map` can be written more simply using `.map`: alvr\server_core\src\tracking\mod.rs#L497

warning: this `.filter_map` can be written more simply using `.map` --> alvr\server_core\src\tracking\mod.rs:497:38 | 497 | let device_motions = device_motion_keys | ______________________________________^ 498 | | .iter() 499 | | .filter_map(move |id| { 500 | | Some(( ... | 505 | | )) 506 | | }) | |______________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map = note: `#[warn(clippy::unnecessary_filter_map)]` on by default

float has excessive precision: alvr\server_core\src\tracking\vmc.rs#L67

warning: float has excessive precision --> alvr\server_core\src\tracking\vmc.rs:67:48 | 67 | Quat::from_xyzw(0.70228, -0.08246, 0.7071100, 0.00000), | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision help: consider changing the type or truncating it to | 67 | Quat::from_xyzw(0.70228, -0.08246, 0.707_11, 0.00000), | ~~~~~~~~

float has excessive precision: alvr\server_core\src\tracking\vmc.rs#L59

warning: float has excessive precision --> alvr\server_core\src\tracking\vmc.rs:59:58 | 59 | Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.7071100), | ^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision = note: `#[warn(clippy::excessive_precision)]` on by default help: consider changing the type or truncating it to | 59 | Quat::from_xyzw(-0.59103, 0.38818, 0.00000, -0.707_11), | ~~~~~~~~

field `platform` is never read: alvr\client_openxr\src\interaction.rs#L103

warning: field `platform` is never read --> alvr\client_openxr\src\interaction.rs:103:5 | 101 | pub struct InteractionContext { | ------------------ field in this struct 102 | xr_session: xr::Session<xr::OpenGlEs>, 103 | platform: Platform, | ^^^^^^^^

fields `aim_action` and `aim_space` are never read: alvr\client_openxr\src\interaction.rs#L50

warning: fields `aim_action` and `aim_space` are never read --> alvr\client_openxr\src\interaction.rs:50:9 | 46 | pub struct HandInteraction { | --------------- fields in this struct ... 50 | pub aim_action: xr::Action<xr::Posef>, | ^^^^^^^^^^ 51 | pub aim_space: xr::Space, | ^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

variable does not need to be mutable: alvr\client_openxr\src\lib.rs#L192

warning: variable does not need to be mutable --> alvr\client_openxr\src\lib.rs:192:9 | 192 | let mut last_lobby_message = String::new(); | ----^^^^^^^^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

unused variable: `xr_frame_stream`: alvr\client_openxr\src\lib.rs#L204

warning: unused variable: `xr_frame_stream` --> alvr\client_openxr\src\lib.rs:204:51 | 204 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe { | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_stream`

unused variable: `xr_frame_waiter`: alvr\client_openxr\src\lib.rs#L204

warning: unused variable: `xr_frame_waiter` --> alvr\client_openxr\src\lib.rs:204:30 | 204 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe { | ^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_frame_waiter`

unused variable: `xr_session`: alvr\client_openxr\src\lib.rs#L204

warning: unused variable: `xr_session` --> alvr\client_openxr\src\lib.rs:204:14 | 204 | let (xr_session, mut xr_frame_waiter, mut xr_frame_stream) = unsafe { | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_xr_session`

unused variable: `last_lobby_message`: alvr\client_openxr\src\lib.rs#L192

warning: unused variable: `last_lobby_message` --> alvr\client_openxr\src\lib.rs:192:13 | 192 | let mut last_lobby_message = String::new(); | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_last_lobby_message` | = note: `#[warn(unused_variables)]` on by default

unreachable definition: alvr\client_openxr\src\lib.rs#L210

warning: unreachable definition --> alvr\client_openxr\src\lib.rs:210:13 | 206 | .create_session(xr_system, &graphics::session_create_info(&graphics_context)) | ------------------------------------------------ any code following this expression is unreachable ... 210 | let views_config = xr_instance | ^^^^^^^^^^^^ unreachable definition | note: this expression has type `openxr::opengles::SessionCreateInfo`, which is uninhabited --> alvr\client_openxr\src\lib.rs:206:45 | 206 | .create_session(xr_system, &graphics::session_create_info(&graphics_context)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: `#[warn(unreachable_code)]` on by default

casting to the same type is unnecessary (`f32` -> `f32`): alvr\server_core\src\bitrate.rs#L133

warning: casting to the same type is unnecessary (`f32` -> `f32`) --> alvr\server_core\src\bitrate.rs:133:25 | 133 | self.packet_bytes_average.get_average() as f32, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.packet_bytes_average.get_average()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

returning the result of a `let` binding from a block: alvr\client_core\src\lib.rs#L364

warning: returning the result of a `let` binding from a block --> alvr\client_core\src\lib.rs:364:9 | 353 | / let view_params = [ 354 | | ViewParams { 355 | | pose: head_pose * view_params[0].pose, 356 | | fov: view_params[0].fov, ... | 361 | | }, 362 | | ]; | |__________- unnecessary `let` binding 363 | 364 | view_params | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 353 ~ 354 | 355 ~ [ 356 + ViewParams { 357 + pose: head_pose * view_params[0].pose, 358 + fov: view_params[0].fov, 359 + }, 360 + ViewParams { 361 + pose: head_pose * view_params[1].pose, 362 + fov: view_params[1].fov, 363 + }, 364 + ] |

very complex type used. Consider factoring parts into `type` definitions: alvr\client_core\src\lib.rs#L312

warning: very complex type used. Consider factoring parts into `type` definitions --> alvr\client_core\src\lib.rs:312:19 | 312 | callback: Box<dyn FnMut(Duration, &[u8]) -> bool + Send>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: alvr\client_core\src\connection.rs#L65

warning: very complex type used. Consider factoring parts into `type` definitions --> alvr\client_core\src\connection.rs:65:27 | 65 | pub decoder_callback: Mutex<Option<Box<dyn FnMut(Duration, &[u8]) -> bool + Send>>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

fields `adapter` and `dummy_surface` are never read: alvr\client_core\src\graphics\mod.rs#L167

warning: fields `adapter` and `dummy_surface` are never read --> alvr\client_core\src\graphics\mod.rs:167:5 | 165 | pub struct GraphicsContext { | --------------- fields in this struct 166 | _instance: Instance, 167 | adapter: Adapter, | ^^^^^^^ ... 174 | dummy_surface: egl::Surface, | ^^^^^^^^^^^^^

variants `Float`, `Int32`, `Int64`, and `String` are never constructed: alvr\client_core\src\c_api.rs#L839

warning: variants `Float`, `Int32`, `Int64`, and `String` are never constructed --> alvr\client_core\src\c_api.rs:839:5 | 838 | pub enum AlvrMediacodecPropType { | ---------------------- variants in this enum 839 | Float, | ^^^^^ 840 | Int32, | ^^^^^ 841 | Int64, | ^^^^^ 842 | String, | ^^^^^^

field `codec` is never read: alvr\client_core\src\c_api.rs#L78

warning: field `codec` is never read --> alvr\client_core\src\c_api.rs:78:9 | 77 | DecoderConfig { | ------------- field in this variant 78 | codec: AlvrCodec, | ^^^^^

fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read: alvr\client_core\src\c_api.rs#L71

warning: fields `device_id`, `duration_s`, `frequency`, and `amplitude` are never read --> alvr\client_core\src\c_api.rs:71:9 | 70 | Haptics { | ------- fields in this variant 71 | device_id: u64, | ^^^^^^^^^ 72 | duration_s: f32, | ^^^^^^^^^^ 73 | frequency: f32, | ^^^^^^^^^ 74 | amplitude: f32, | ^^^^^^^^^

fields `view_width`, `view_height`, `refresh_rate_hint`, `encoding_gamma`, `enable_foveated_encoding`, and `enable_hdr` are never read: alvr\client_core\src\c_api.rs#L62

warning: fields `view_width`, `view_height`, `refresh_rate_hint`, `encoding_gamma`, `enable_foveated_encoding`, and `enable_hdr` are never read --> alvr\client_core\src\c_api.rs:62:9 | 61 | StreamingStarted { | ---------------- fields in this variant 62 | view_width: u32, | ^^^^^^^^^^ 63 | view_height: u32, | ^^^^^^^^^^^ 64 | refresh_rate_hint: f32, | ^^^^^^^^^^^^^^^^^ 65 | encoding_gamma: f32, | ^^^^^^^^^^^^^^ 66 | enable_foveated_encoding: bool, | ^^^^^^^^^^^^^^^^^^^^^^^^ 67 | enable_hdr: bool, | ^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

fields `remote` and `serial` are never read: alvr\adb\src\parse.rs#L126

warning: fields `remote` and `serial` are never read --> alvr\adb\src\parse.rs:126:9 | 124 | pub struct ForwardedPorts { | -------------- fields in this struct 125 | pub local: u16, 126 | pub remote: u16, | ^^^^^^ 127 | pub serial: String, | ^^^^^^ | = note: `ForwardedPorts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

fields `connection_state`, `device`, `model`, `product`, and `transport_type` are never read: alvr\adb\src\parse.rs#L75

warning: fields `connection_state`, `device`, `model`, `product`, and `transport_type` are never read --> alvr\adb\src\parse.rs:75:9 | 74 | pub struct Device { | ------ fields in this struct 75 | pub connection_state: Option<ConnectionState>, | ^^^^^^^^^^^^^^^^ 76 | pub device: Option<String>, | ^^^^^^ 77 | pub model: Option<String>, | ^^^^^ 78 | pub product: Option<String>, | ^^^^^^^ 79 | pub serial: Option<String>, 80 | pub transport_type: Option<TransportType>, | ^^^^^^^^^^^^^^ | = note: `Device` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

function `list_installed_packages` is never used: alvr\adb\src\commands.rs#L240

warning: function `list_installed_packages` is never used --> alvr\adb\src\commands.rs:240:8 | 240 | pub fn list_installed_packages(adb_path: &str, device_serial: &str) -> Result<HashSet<String>> { | ^^^^^^^^^^^^^^^^^^^^^^^

function `uninstall_package` is never used: alvr\adb\src\commands.rs#L229

warning: function `uninstall_package` is never used --> alvr\adb\src\commands.rs:229:8 | 229 | pub fn uninstall_package(adb_path: &str, device_serial: &str, application_id: &str) -> Result<()> { | ^^^^^^^^^^^^^^^^^

function `is_package_installed` is never used: alvr\adb\src\commands.rs#L215

warning: function `is_package_installed` is never used --> alvr\adb\src\commands.rs:215:8 | 215 | pub fn is_package_installed( | ^^^^^^^^^^^^^^^^^^^^

function `install_package` is never used: alvr\adb\src\commands.rs#L207

warning: function `install_package` is never used --> alvr\adb\src\commands.rs:207:8 | 207 | pub fn install_package(adb_path: &str, device_serial: &str, apk_path: &str) -> Result<()> { | ^^^^^^^^^^^^^^^

function `start_application` is never used: alvr\adb\src\commands.rs#L168

warning: function `start_application` is never used --> alvr\adb\src\commands.rs:168:8 | 168 | pub fn start_application(adb_path: &str, device_serial: &str, application_id: &str) -> Result<()> { | ^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

unused imports: `InstanceDescriptor` and `InstanceFlags`: alvr\client_core\src\graphics\mod.rs#L15

warning: unused imports: `InstanceDescriptor` and `InstanceFlags` --> alvr\client_core\src\graphics\mod.rs:15:42 | 15 | Adapter, Device, Extent3d, Instance, InstanceDescriptor, InstanceFlags, Queue, Texture, | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^

unused import: `mem`: alvr\client_core\src\graphics\mod.rs#L12

warning: unused import: `mem` --> alvr\client_core\src\graphics\mod.rs:12:24 | 12 | use std::{ffi::c_void, mem, num::NonZeroU32, ptr}; | ^^^ | = note: `#[warn(unused_imports)]` on by default

function `build_windows_installer` is never used: alvr\xtask\src\packaging.rs#L21

warning: function `build_windows_installer` is never used --> alvr\xtask\src\packaging.rs:21:4 | 21 | fn build_windows_installer() { | ^^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

check-windows

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, ErichDonGubler/clippy-check@fix-windows-lf-breaking-reports. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

check-windows

The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions-rs/toolchain@v1, Swatinem/rust-cache@v1, ErichDonGubler/clippy-check@fix-windows-lf-breaking-reports. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

check-windows

check-linux

It seems that this Action is executed from the forked repository.

check-linux

GitHub Actions are not allowed to create Check annotations, when executed for a forked repos. See https://github.com/actions-rs/clippy-check/issues/2 for details.

check-linux

check-msrv-windows

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(client_openxr): ♻️ Do not recreate OpenXR session #4469

Summary

refactor(client_openxr): ♻️ Do not recreate OpenXR session #4469

Jobs

Run details

rust.yml

Annotations