Better treatment of invalid commands --> decreasing risk of getting stuck in the bootloader #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially when using DShot bidir I found the following scenario happening sometimes:
The bootloaders sometimes picks up DShot Bidir commands up as commands 0xFF ("CMD_SET_ADDRESS"). With invalid CRC of course. But nevertheless invalid command is never increased (since 0xFF is a valid command) and the ESC is stuck in the bootloader.
Solution:
So when we increase invalid_command whenevver we have bad CRC or unknown commands, we reduce the risk of being stuck in the bootloader and waiting for commands. As soon as we receive a valid command we set invalid_command to 0.