feat: Introduce run_multiple method
#264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #264 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 3791 3802 +11
Branches 927 930 +3
=========================================
+ Hits 3791 3802 +11 ☔ View full report in Codecov by Sentry. |
krneta
previously approved these changes
Jun 19, 2024
speller26
commented
Jun 23, 2024
test/unit_tests/braket/default_simulator/test_density_matrix_simulator.py
Outdated
Show resolved
Hide resolved
test/unit_tests/braket/default_simulator/test_density_matrix_simulator.py
Outdated
Show resolved
Hide resolved
test/unit_tests/braket/default_simulator/test_state_vector_simulator.py
Outdated
Show resolved
Hide resolved
test/unit_tests/braket/default_simulator/test_state_vector_simulator.py
Outdated
Show resolved
Hide resolved
speller26
commented
Jun 23, 2024
5 tasks
kshyatt-aws
reviewed
Jun 25, 2024
test/unit_tests/braket/default_simulator/test_density_matrix_simulator.py
Outdated
Show resolved
Hide resolved
kshyatt-aws
reviewed
Jun 25, 2024
| expected_measurements = [[1, 0], [0, 1], [1, 1]] | ||
| simulator = DensityMatrixSimulator() | ||
| for result, payload_args, expected in zip( | ||
| simulator.run_multiple(payloads, args=args), args, expected_measurements |
There was a problem hiding this comment.
aren't you missing a kwargs=kwargs here?
There was a problem hiding this comment.
Ah I see what's going on. IMO this is pretty confusing, to allow shots to be in either
kshyatt-aws
reviewed
Jun 25, 2024
test/unit_tests/braket/default_simulator/test_state_vector_simulator.py
Outdated
Show resolved
Hide resolved
kshyatt-aws
reviewed
Jun 25, 2024
| Args: | ||
| payloads (Sequence[Union[OQ3Program, AHSProgram, JaqcdProgram]]): The IR representations | ||
| of the programs | ||
| args (Optional[Sequence[Sequence[Any]]]): The positional args to include with |
There was a problem hiding this comment.
Can I only submit one of args and kwargs? Is the intent that specifying shots in kwargs should override any value in args?
There was a problem hiding this comment.
You can specify both, just as you can technically
device.run(circuit, 1000, shots=1000)it'll just error out with something like
LocalSimulator.run() got multiple values for argument 'shots'
5 tasks
AbeCoull
reviewed
Jun 27, 2024
rmshaffer
previously approved these changes
Jun 27, 2024
rmshaffer
previously approved these changes
Jun 27, 2024
krneta
reviewed
Jun 27, 2024
krneta
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Introduces
run_multiplemethod toBraketSimulatorto allow backends to leverage their own batching implementations. Will next publish SDK PR to make use of this interface.Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.