Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename 2_Graph_optimization_with_QAOA.ipynb to 2_max_cliqu… #333

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JDWhitfieldAWS
Copy link
Contributor

…e_with_QAOA.ipynb

Enhancing discoverability by updating notebook name to include specific graph problem.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…e_with_QAOA.ipynb

Enhancing discoverability by updating notebook name to include specific graph problem.
@JDWhitfieldAWS JDWhitfieldAWS requested a review from a team as a code owner August 21, 2023 20:18
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@rmshaffer rmshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, can you expand on the motivation for this change? This notebook actually contains examples of both "max clique" and "max cut" problems, so I'm not sure the new suggested title is exactly right.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor thing, but for consistency I think the M in the filename should be capitalized:
2_Max_clique_with_QAOA.ipynb

Also I guess the folder name should also be updated to match? i.e., the new file path should be
examples/pennylane/2_Max_clique_with_QAOA/2_Max_clique_with_QAOA.ipynb

But see also the general comment about whether this is the right name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants