Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zero symbol to return default import location #97

Merged
merged 6 commits into from
Mar 27, 2020

Conversation

byronlin13
Copy link
Contributor

Issue #, if available:
Resolves #89

Description of changes:

  • Updated zero symbol to return a default import location.
  • Update unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need equivalent changes in the binary readers?

Amazon.IonDotnet/Internals/Text/SystemTextReader.cs Outdated Show resolved Hide resolved
@byronlin13
Copy link
Contributor Author

Do we need equivalent changes in the binary readers?

In Binary readers GetTypeAnnotations(), we don't need to make the equivalent changes because we get the Sid from the Annotations list from RawBinaryReaders instead of ImportLocation.Sid

https://github.com/amzn/ion-dotnet/blob/master/Amazon.IonDotnet/Internals/Binary/SystemBinaryReader.cs#L288-L303

Copy link
Contributor

@tgregg tgregg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tgregg tgregg merged commit d01176a into amazon-ion:master Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of zero symbol has non-null import location
2 participants