Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge hive2 and hive3 support into one branch as Gradle subprojects #108

Merged
merged 37 commits into from
Mar 1, 2024

Conversation

popematt
Copy link
Contributor

@popematt popematt commented Jan 5, 2024

Issue #, if available:

None

Description of changes:

  • Merges hive2 and hive3 support into one GitHub branch as Gradle subprojects
    • This is one way that does work. It might not be the best way. It may be possible to restructure the project a little more simply like in emr-dynamodb-connector. It might also be possible to move the different versions into one subproject with multiple source sets.
  • The serde subproject of the hive2 branch has been moved to a hive2 subproject. Similarly for hive3.
  • Updates to Gradle 8.5
  • Uses the shadowJar plugin instead of having a custom task for building the fat jars.
  • Removes the transitive dependency on the Kotlin Standard Library from the fat jars. (It was brought in somehow even though it was used only for test code.)
  • Converts most build files to Kotlin. The only files still using groovy are integration-test/build.gradle and the (now trivial) root build script.
  • Parts of the build logic that are shared have been extracted into Gradle convention plugins in the buildSrc directory.
  • All projects in this repo now have the same version (currently 1.3.0-SNAPSHOT).
  • Copyright header was updated to be shorter, SPDX-compatible, and not mention the year 2018.

Limitations:

  • Integration tests currently target only the hive2 subproject.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jobarr-amzn and others added 30 commits March 2, 2022 14:51
* Fixes broken badge and adds hive2 branch to GHA workflow.
* Edit readme for hive2 support.
* In addition to NPE, this PR addressed general null type handle issue for ion-hive-serde.
@popematt popematt marked this pull request as draft January 5, 2024 22:47
@popematt popematt marked this pull request as ready for review January 10, 2024 23:20
build.gradle Outdated Show resolved Hide resolved
import com.amazon.ion.UnknownSymbolException;
import com.amazon.ion.ValueFactory;

import com.amazon.ion.*;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we feel about wildcard imports? I know in other projects we've leaned away from it, I don't really care one way or another so long as we're consistent.

Personally I have a lot of sympathy for this argument: https://stackoverflow.com/a/149282 .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there isn't necessarily consensus about wildcard imports in general, but I think there's absolutely no problem with wildcard imports of other packages that we also maintain.

@popematt popematt merged commit f8e9b0c into amazon-ion:master Mar 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants