-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge hive2 and hive3 support into one branch as Gradle subprojects #108
Conversation
* Fixes broken badge and adds hive2 branch to GHA workflow. * Edit readme for hive2 support.
* In addition to NPE, this PR addressed general null type handle issue for ion-hive-serde.
import com.amazon.ion.UnknownSymbolException; | ||
import com.amazon.ion.ValueFactory; | ||
|
||
import com.amazon.ion.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we feel about wildcard imports? I know in other projects we've leaned away from it, I don't really care one way or another so long as we're consistent.
Personally I have a lot of sympathy for this argument: https://stackoverflow.com/a/149282 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know there isn't necessarily consensus about wildcard imports in general, but I think there's absolutely no problem with wildcard imports of other packages that we also maintain.
Issue #, if available:
None
Description of changes:
serde
subproject of thehive2
branch has been moved to ahive2
subproject. Similarly forhive3
.shadowJar
plugin instead of having a custom task for building the fat jars.integration-test/build.gradle
and the (now trivial) root build script.buildSrc
directory.1.3.0-SNAPSHOT
).Limitations:
hive2
subproject.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.