Address ion-test-driver failure by upgrading pip with setup-python action. #875
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #875 +/- ##
============================================
+ Coverage 67.23% 67.67% +0.43%
- Complexity 5484 5522 +38
============================================
Files 159 159
Lines 23025 22982 -43
Branches 4126 4108 -18
============================================
+ Hits 15481 15553 +72
+ Misses 6262 6155 -107
+ Partials 1282 1274 -8 ☔ View full report in Codecov by Sentry. |
nirosys
force-pushed
the
rgiliam/workflow_python_setup
branch
from
3cf9041
to
c8e1567
Compare
There was a problem hiding this comment.
Nice! Thanks for fixing this.
Note that we recently changed ion-tests to restore the old iontestdata directory: amazon-ion/ion-tests#93
Maybe we can just make a quick update to ion-test-driver to point the 1.0 branch at iontestdata so we can keep pointing at master here? (see amazon-ion/ion-test-driver@1815f9c)
|
Yea, I'll put a PR together to update ion-test-driver to match the ion-tests change. I'll try to get that together before EoD, then I can set this PR back to use master. |
Co-authored-by: Tyler Gregg <[email protected]>
…tion. (#875) * Use setup-python to force pip upgrade; fixes error with pip 22.0 * Roll ion-test-driver back to pre-1.1/1.0 split * Revert ion-test-driver reference back to master Co-authored-by: Tyler Gregg <[email protected]> --------- Co-authored-by: Tyler Gregg <[email protected]>
…tion. (#875) * Use setup-python to force pip upgrade; fixes error with pip 22.0 * Roll ion-test-driver back to pre-1.1/1.0 split * Revert ion-test-driver reference back to master Co-authored-by: Tyler Gregg <[email protected]> --------- Co-authored-by: Tyler Gregg <[email protected]>
Issue #, if available: #795
Description of changes:
It appears that the issue causing the ion-test-driver failure is related to an issue found in pip 22.0. This PR adds the setup-python action to force a pip upgrade (and ensure python version).
A run of the workflow can be seen here.
In addition to the setup-python change, I also had to roll-back the revision of ion-test-driver that was being used to before the 1.0 and 1.1 split was made. The workflow was pulling master, which has been using the directory split for a while, but it appears the iontests used by this repo is from before versioned directories were added.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.