Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to eslint #730

Closed
wants to merge 2 commits into from
Closed

Migrate to eslint #730

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 11, 2022

Issue #, if available:

#729

Description of changes:

TSLint is not evolving anymore, it is recommended to migrate to ESLint and that's what this PR is doing. I have also disabled all recommended rules that fail for current code base - can be fixed in further PRs. Notes:

  • TSLint was not connected to builds at all, and when I tried to run it manually multiple checks failed. I am enabling linting checks as a part of build process.
  • We cannot use the latest versions of ESLint and plugins as this library still supports Node v10.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@zslayton
Copy link
Contributor

Thanks for putting this together! I notice it's still in draft mode, were you planning to wait until the dependency on node v10 was removed?

@zslayton
Copy link
Contributor

Could you have this target the 5.0.0-development branch so we can include it in the next release? The dependency on Node v10 has already been removed there.

@ghost ghost closed this by deleting the head repository Dec 13, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant