Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catalog parameter to makeReader #768

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Conversation

everett1992
Copy link
Contributor

@everett1992 everett1992 commented Aug 26, 2023

This allows users to create a reader with a catalog

fixes #765


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This allows users to create a reader with a catalog

fixes amazon-ion#765
Copy link
Contributor

@desaikd desaikd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @everett1992!
The change looks good, I have just added a minor comment.

src/Ion.ts Show resolved Hide resolved
@desaikd desaikd merged commit 2fe2f03 into amazon-ion:master Sep 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shared symbol tables is advertised in readme but in private implementation.
2 participants