Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds reusable RawValueExpr::resolve method #854

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

zslayton
Copy link
Contributor

@zslayton zslayton commented Nov 8, 2024

This PR contains no new features, just a refactor.

There are some complex generics around the RawValueExpr type (described in dev comments therein) that made writing a centralized, reusable resolve method difficult to express. I guess I'm older and wiser now, though, 'cause I managed to figure it out this time around.

Along with adding the resolve method, I removed two places where the same logic had been implemented.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.27%. Comparing base (f36249e) to head (93870d8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lazy/expanded/e_expression.rs 33.33% 0 Missing and 2 partials ⚠️
src/lazy/decoder.rs 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #854   +/-   ##
=======================================
  Coverage   77.26%   77.27%           
=======================================
  Files         135      135           
  Lines       33415    33408    -7     
  Branches    33415    33408    -7     
=======================================
- Hits        25819    25815    -4     
+ Misses       5654     5650    -4     
- Partials     1942     1943    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zslayton zslayton merged commit 36c3dca into main Nov 8, 2024
35 checks passed
@zslayton zslayton deleted the raw-expr-resolve branch November 8, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants