Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds writers for SchemaDocument and types #294

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

popematt
Copy link
Contributor

Issue #, if available:

None

Description of changes:

  • Changes IonSchemaWriter to be an object and the entry point to writing an Ion Schema.
  • Creates an internal interface called VersionedIonSchemaWriter to replace the former IonSchemaWriter
  • Adds ISL 2.0 writer implementations for Types and SchemaDocuments
  • Creates a test harness that uses ion-schema-tests with the Ion Schema writer.

Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:

None.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...lin/com/amazon/ionschema/writer/IonSchemaWriter.kt 100.00% <100.00%> (ø)
...n/ionschema/writer/internal/IonSchemaWriterV2_0.kt 71.42% <71.42%> (ø)
...amazon/ionschema/writer/internal/TypeWriterV2_0.kt 78.12% <78.12%> (ø)

... and 21 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@popematt popematt merged commit db871db into amazon-ion:master Oct 25, 2023
4 of 5 checks passed
@popematt popematt deleted the writer-part-6 branch October 25, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants