Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ion-schema-tests and related fixes for ISL 2.0 #200

Merged
merged 9 commits into from
Sep 26, 2023

Conversation

desaikd
Copy link
Contributor

@desaikd desaikd commented Sep 19, 2023

Description of changes:

This PR adds from remaining ion-schema-tests for ISL 2.0 and related bug fixes.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

ion-schema/src/isl/isl_constraint.rs Outdated Show resolved Hide resolved
ion-schema/src/isl/ranges.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@popematt popematt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. I started a review, and forgot to publish it.

There's one minor change that needs to be made (for which I've added a suggested change), and there's a spot where you could DRY up the code a bit.

ion-schema/src/isl/isl_constraint.rs Outdated Show resolved Hide resolved
ion-schema/src/isl/ranges.rs Outdated Show resolved Hide resolved
@desaikd desaikd merged commit c4f46f4 into main Sep 26, 2023
5 checks passed
@desaikd desaikd deleted the desaikd-isl2-0-tests branch January 16, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants