Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for programmatically adding closed fields #218

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

desaikd
Copy link
Contributor

@desaikd desaikd commented Sep 10, 2024

Issue #217

Description of changes:

This PR works on adding support programmatically adding closed fields.

List of changes:

  • Modified fields constraint API to add a boolean representing fields are closed or not.
  • Added relevant test for closed fields

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@popematt popematt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment about naming. Otherwise it looks good.

ion-schema/src/isl/isl_constraint.rs Outdated Show resolved Hide resolved
@desaikd desaikd merged commit be856c2 into main Sep 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants