Add support for programmatically adding closed fields
(#218)
#646
clippy
15 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 15 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.81.0 (eeb90cda1 2024-09-04)
- cargo 1.81.0 (2dbb1af80 2024-08-20)
- clippy 0.1.81 (eeb90cd 2024-09-04)
Annotations
Check warning on line 95 in ion-schema/src/system.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/system.rs:95:9
|
95 | /// Otherwise, returns false if this update is for an isl import type and it is not yet added to the type_store.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
95 | /// Otherwise, returns false if this update is for an isl import type and it is not yet added to the type_store.
| ++
Check warning on line 94 in ion-schema/src/system.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/system.rs:94:9
|
94 | /// Returns true, if this update is not for an isl import type or it is for an isl import type but it is added to the type_store
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
94 | /// Returns true, if this update is not for an isl import type or it is for an isl import type but it is added to the type_store
| ++
Check warning on line 54 in ion-schema/src/system.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/system.rs:54:5
|
54 | /// [`PendingTypes`] can be promoted the [`TypeStore`].
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
54 | /// [`PendingTypes`] can be promoted the [`TypeStore`].
| ++
Check warning on line 53 in ion-schema/src/system.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/system.rs:53:5
|
53 | /// [`SchemaSystem`] finishes loading these types, the type definitions in
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
53 | /// [`SchemaSystem`] finishes loading these types, the type definitions in
| ++
Check warning on line 52 in ion-schema/src/system.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/system.rs:52:5
|
52 | /// that we do not have a complete definition for yet. When the
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
52 | /// that we do not have a complete definition for yet. When the
| ++
Check warning on line 51 in ion-schema/src/system.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/system.rs:51:5
|
51 | /// An instance of [`PendingTypes`] is used to track information about types
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
51 | /// An instance of [`PendingTypes`] is used to track information about types
| ++
Check warning on line 50 in ion-schema/src/system.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/system.rs:50:5
|
50 | /// of these types, it cannot find them in the [`TypeStore`].
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
50 | /// of these types, it cannot find them in the [`TypeStore`].
| ++
Check warning on line 49 in ion-schema/src/system.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/system.rs:49:5
|
49 | /// Because the [`SchemaSystem`] does not yet know the complete definition
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
49 | /// Because the [`SchemaSystem`] does not yet know the complete definition
| ++
Check warning on line 6 in ion-schema/src/schema.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/schema.rs:6:5
|
6 | //! It returns the [`TypeDefinition`] if it is defined in the [`Schema`] otherwise returns [`None`].
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
6 | //! It returns the [`TypeDefinition`] if it is defined in the [`Schema`] otherwise returns [`None`].
| ++
Check warning on line 15 in ion-schema/src/isl/mod.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/isl/mod.rs:15:5
|
15 | //! The type reference grammar is defined in the [Ion Schema Specification]
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
15 | //! The type reference grammar is defined in the [Ion Schema Specification]
| ++
Check warning on line 12 in ion-schema/src/isl/mod.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/isl/mod.rs:12:5
|
12 | //! which converts given ion content in the schema file into an ISL constraint(not-yet-resolved constraints).
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
12 | //! which converts given ion content in the schema file into an ISL constraint(not-yet-resolved constraints).
| ++
Check warning on line 9 in ion-schema/src/isl/mod.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/isl/mod.rs:9:5
|
9 | //! into an ISL import. It stores schema id, an optional type that needs to be imported and an optional alias to that type.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
help: indent this line
|
9 | //! into an ISL import. It stores schema id, an optional type that needs to be imported and an optional alias to that type.
| ++
Check warning on line 6 in ion-schema/src/isl/mod.rs
github-actions / clippy
doc list item without indentation
warning: doc list item without indentation
--> ion-schema/src/isl/mod.rs:6:5
|
6 | //! into an ISL types(not-yet-resolved types). It stores `IslConstraint`s defined within the given type.
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
|
6 | //! into an ISL types(not-yet-resolved types). It stores `IslConstraint`s defined within the given type.
| ++
Check warning on line 1198 in ion-schema/src/constraint.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> ion-schema/src/constraint.rs:1191:29
|
1191 | / ... &format!(
1192 | | ... "expected list/sexp/struct/document found {}",
1193 | | ... if element.is_null() {
1194 | | ... format!("{element}")
... |
1197 | | ... }
1198 | | ... ),
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
help: change this to
|
1191 ~ format!(
1192 + "expected list/sexp/struct/document found {}",
1193 + if element.is_null() {
1194 + format!("{element}")
1195 + } else {
1196 + format!("{}", element.ion_type())
1197 + }
1198 ~ ),
|
Check warning on line 1050 in ion-schema/src/constraint.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> ion-schema/src/constraint.rs:1045:21
|
1045 | / &format!(
1046 | | "Expected {} of field {}: found {}",
1047 | | occurs_range,
1048 | | field_name,
1049 | | values.len()
1050 | | ),
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
help: change this to
|
1045 ~ format!(
1046 + "Expected {} of field {}: found {}",
1047 + occurs_range,
1048 + field_name,
1049 + values.len()
1050 ~ ),
|