Fix invalid C# code in data set #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment for the method shows the wrong value 15.0 being returned from the Median method for the values -10, 4, 6, 1000, 10, 20. The test checking the return value uses the correct value 8.0. Update the comment to use the correct value since this seems to affect the result generated.
Test code was using 'var expected1 = null' which is invalid in C#. Change this to be 'string? expected1 = null' and also change the return type of the Longest method to be string? instead of object.
Test code was using 'var expected3 = null' which is invalid C#. Change the code to use int? instead. Also change the NextSmallest method to return int? instead of object.
A test was trying to store -9999999999999999 in an int. Use long instead of int so this value can be stored.
Test code was using 'var expected4 = null' which is invalid C#. Use int? instead and also change the ProdSigns method to return an int? instead of an object.
A test was using 'var expected8 = null' which is invalid C#. Use int? instead of var and also change the CompareOne method to return object? instead of object since it supports returning null.
The DoAlgebra method was using 'operator' as a parameter name which is invalid in C#. Use '@operator' instead.
A test was using 'var expected2 = null' which is invalid C#. Use string? instead of var. Also change the StringToMd5 method to return a string? instead of an object.
|
Thank you for your PR. We really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #13
Description of changes:
Fix invalid code in HumanEval_csharp/12
Test code was using 'var expected1 = null' which is invalid in C#.
Change this to be 'string? expected1 = null' and also change the
return type of the Longest method to be string? instead of object.
Fix comment in HumanEval_csharp/47
The comment for the method shows the wrong value 15.0 being returned
from the Median method for the values -10, 4, 6, 1000, 10, 20. The
test checking the return value uses the correct value 8.0. Update
the comment to use the correct value since this seems to affect the
result generated.
Fix invalid code in HumanEval_csharp/90
Test code was using 'var expected3 = null' which is invalid C#.
Change the code to use int? instead. Also change the NextSmallest
method to return int? instead of object.
Fix invalid code in HumanEval_csharp/114
A test was trying to store -9999999999999999 in an int. Use long
instead of int so this value can be stored.
Fix invalid code in HumanEval_csharp/128
Test code was using 'var expected4 = null' which is invalid C#.
Use int? instead and also change the ProdSigns method to return an
int? instead of an object.
Fix invalid code in HumanEval_csharp/137
A test was using 'var expected8 = null' which is invalid C#. Use
int? instead of var and also change the CompareOne method to return
object? instead of object since it supports returning null.
Fix invalid code in HumanEval_csharp/160
The DoAlgebra method was using 'operator' as a parameter name
which is invalid in C#. Use '@operator' instead.
Fix invalid code in HumanEval_csharp/162
A test was using 'var expected2 = null' which is invalid C#. Use
string? instead of var. Also change the StringToMd5 method to return
a string? instead of an object.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.