[CLI] change the default recipe source URL #764
Conversation
Issue: amberframework#750 RE: amberframework/recipes#2 Change the default recipe source URL to add the dist folder and support URLs as a recipe name. - changes the default recipe source URL - adds support for a URL as a recipe name
remove spec testing recipe in cache in parent folder
|
This is ready to be merged - we have changed the recipes repository to match this PR |
|
Requires #783 to fix Travis specs BTW, I already working on I know @drujensen have some concerns, although I still think recipes is a great Idea, @drujensen recipes are not shards, they are just pre-created amber projects 😅 The main issue is because we (some of us, including me 😉 ) want to store all blessed recipes in only one repository. This have some pitfalls, although I think I already managed to solved them, just let me publish my ideas (still writing them 😅 ) |
There was a problem hiding this comment.
We should fix Travis spec 👇
Error opening file '/home/travis/build/amberframework/amber/tmp/test_app/shard.yml' with mode 'r': No such file or directory (Errno)
from /usr/share/crystal/src/file.cr:33:5 in 'initialize'
from /usr/share/crystal/src/file.cr:25:3 in 'new'
from /usr/share/crystal/src/file.cr:427:5 in 'read'
from /usr/share/crystal/src/file.cr:441:3 in 'read'
from spec/support/helpers/cli_helper.cr:80:13 in 'prepare_yaml'
from spec/support/helpers/cli_helper.cr:100:5 in 'scaffold_app'
from /usr/share/crystal/src/spec/expectations.cr:0:7 in '~procProc(Nil)'
from /usr/share/crystal/src/spec/context.cr:255:3 in 'describe'
from /usr/share/crystal/src/spec/methods.cr:16:5 in 'describe'
from /usr/share/crystal/src/spec/methods.cr:25:5 in 'context'
from /usr/share/crystal/src/spec/methods.cr:0:5 in '~procProc(Nil)'
from /usr/share/crystal/src/spec/context.cr:255:3 in 'describe'
from /usr/share/crystal/src/spec/methods.cr:16:5 in 'describe'
from spec/amber/cli/commands/init_spec.cr:7:3 in '__crystal_main'
from /usr/share/crystal/src/crystal/main.cr:11:3 in '_crystal_main'
from /usr/share/crystal/src/crystal/main.cr:112:5 in 'main_user_code'
from /usr/share/crystal/src/crystal/main.cr:101:7 in 'main'
from /usr/share/crystal/src/crystal/main.cr:135:3 in 'main'
from __libc_start_main
from ???
from ???
@damianham Any idea why is this failing?
Please see: https://travis-ci.org/amberframework/amber/builds/378226262#L696 😅
|
Hi @damianham I think we should update the URL to: WDYT? |
|
@faustinoaq @damianham what is the status on this? |
|
@drujensen This ready and is required by recipes, I'm already working on removing duplicated code from recipes, see: amberframework/recipes#16 I think we should try current recipe implementation by @damianham , then, after some iterations we can try to move it to shards or something better 👍 |
Issue: #750
RE: amberframework/recipes#3
Change the default recipe source URL to add the dist folder and support
URLs as a recipe name.
Description of the Change
Alternate Designs
Benefits
Possible Drawbacks