Skip to content

Commit

Permalink
Version 4.9.37
Browse files Browse the repository at this point in the history
  • Loading branch information
martynasma committed Aug 21, 2020
1 parent f0e5ab3 commit c08fdcd
Show file tree
Hide file tree
Showing 17 changed files with 44 additions and 15 deletions.
6 changes: 6 additions & 0 deletions dist/ember/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
Please note, that this project, while following numbering syntax, it DOES NOT
adhere to [Semantic Versioning](http://semver.org/spec/v2.0.0.html) rules.

## [4.9.37] - 2020-08-21

### Fixed
- Colors for markers in Legend with `useDefaultMarkers = true` were broken since last release.


## [4.9.36] - 2020-08-20

### Added
Expand Down
2 changes: 1 addition & 1 deletion dist/ember/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@amcharts/amcharts4-ember",
"version": "4.9.36",
"version": "4.9.37",
"description": "Ember add-on for amCharts 4",
"keywords": [
"ember-addon",
Expand Down
6 changes: 6 additions & 0 deletions dist/ember/vendor/script/amcharts4/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
Please note, that this project, while following numbering syntax, it DOES NOT
adhere to [Semantic Versioning](http://semver.org/spec/v2.0.0.html) rules.

## [4.9.37] - 2020-08-21

### Fixed
- Colors for markers in Legend with `useDefaultMarkers = true` were broken since last release.


## [4.9.36] - 2020-08-20

### Added
Expand Down
2 changes: 1 addition & 1 deletion dist/ember/vendor/script/amcharts4/core.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/ember/vendor/script/amcharts4/core.js.map

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion dist/es2015/.internal/charts/Legend.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/es2015/.internal/charts/Legend.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/es2015/.internal/core/System.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/es2015/.internal/core/System.js.map

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions dist/es2015/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
Please note, that this project, while following numbering syntax, it DOES NOT
adhere to [Semantic Versioning](http://semver.org/spec/v2.0.0.html) rules.

## [4.9.37] - 2020-08-21

### Fixed
- Colors for markers in Legend with `useDefaultMarkers = true` were broken since last release.


## [4.9.36] - 2020-08-20

### Added
Expand Down
2 changes: 1 addition & 1 deletion dist/es2015/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@amcharts/amcharts4",
"version": "4.9.36",
"version": "4.9.37",
"author": "amCharts <[email protected]> (https://www.amcharts.com/)",
"description": "amCharts 4",
"homepage": "https://www.amcharts.com/",
Expand Down
6 changes: 6 additions & 0 deletions dist/script/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
Please note, that this project, while following numbering syntax, it DOES NOT
adhere to [Semantic Versioning](http://semver.org/spec/v2.0.0.html) rules.

## [4.9.37] - 2020-08-21

### Fixed
- Colors for markers in Legend with `useDefaultMarkers = true` were broken since last release.


## [4.9.36] - 2020-08-20

### Added
Expand Down
2 changes: 1 addition & 1 deletion dist/script/core.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/script/core.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@amcharts/amcharts4",
"version": "4.9.36",
"version": "4.9.37",
"repository": {
"type": "git",
"url": "https://github.com/amcharts/amcharts4.git"
Expand Down
8 changes: 5 additions & 3 deletions src/.internal/charts/Legend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ export class Legend extends Component {
rectangle.width = percent(100);
rectangle.height = percent(100);
rectangle.applyOnClones = true;
//rectangle.propertyFields.fill = "fill"; //othrwise old edge doesn't like as the same pattern is set both on parent and child https://codepen.io/team/amcharts/pen/72d7a98f3fb811d3118795220ff63182
rectangle.propertyFields.fill = "fill"; //othrwise old edge doesn't like as the same pattern is set both on parent and child https://codepen.io/team/amcharts/pen/72d7a98f3fb811d3118795220ff63182
rectangle.strokeOpacity = 0;

// Create a template container and list for item labels
Expand Down Expand Up @@ -663,7 +663,6 @@ export class Legend extends Component {
*/
public validateDataElement(dataItem: this["_dataItem"]): void {
super.validateDataElement(dataItem);

// Get data item (legend item's) container
let container = dataItem.itemContainer;

Expand All @@ -680,7 +679,7 @@ export class Legend extends Component {

let tempMaxWidth = dataItem.label.maxWidth;
dataItem.label.width = undefined;
if(tempMaxWidth > 0){
if (tempMaxWidth > 0) {
dataItem.label.maxWidth = tempMaxWidth;
}
if (valueLabel.align == "right") {
Expand All @@ -699,6 +698,9 @@ export class Legend extends Component {
dataItem.childrenCreated = true;
}
}
else {
this.markers.template.propertyFields.fill = undefined;
}

if (dataContext.updateLegendValue) {
dataContext.updateLegendValue(); // this solves issue with external legend, as legend is created after chart updates legend values
Expand Down
2 changes: 1 addition & 1 deletion src/.internal/core/System.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class System {
*
* @see {@link https://docs.npmjs.com/misc/semver}
*/
static VERSION: string = "4.9.36";
static VERSION: string = "4.9.37";

/**
* @todo Description
Expand Down

0 comments on commit c08fdcd

Please sign in to comment.