Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various improvements to ament_python_install_package #372

Open
wants to merge 7 commits into
base: rolling
Choose a base branch
from
Open

Various improvements to ament_python_install_package #372

wants to merge 7 commits into from
+13 −24

Commits on Jan 6, 2022

  1. Always use USE_SOURCE_PERMISSIONS 

    The scripts are generated into a build folder and thus *always* need to be copied.
No need to distinguish between symlink and other installs.

Signed-off-by: Robert Haschke <[email protected]>
    @rhaschke
    rhaschke committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    d6c749a View commit details
    Browse the repository at this point in the history

  2. Make SCRIPTS_DESTINATION argument optional 

    Signed-off-by: Robert Haschke <[email protected]>
    @rhaschke
    rhaschke committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    a786aa2 View commit details
    Browse the repository at this point in the history

  3. Directly generate scripts into install location 

    This avoids the problem of empty install folders as setup.py
generates the target folder only if needed.

Signed-off-by: Robert Haschke <[email protected]>
    @rhaschke
    rhaschke committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    321105d View commit details
    Browse the repository at this point in the history

  4. Silence policy CMP0087 warning 

    Signed-off-by: Robert Haschke <[email protected]>
    @rhaschke
    rhaschke committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    fe6b3a3 View commit details
    Browse the repository at this point in the history

  5. Support multiple SCRIPTS_DESTINATIONs 

    For example, xacro is install into lib/xacro/xacro and bin/xacro.

Signed-off-by: Robert Haschke <[email protected]>
    @rhaschke
    rhaschke committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    d29798e View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2022

  1. Revert "Silence policy CMP0087 warning" 

    This reverts commit fe6b3a3.

Signed-off-by: Robert Haschke <[email protected]>
    @rhaschke
    rhaschke committed Feb 8, 2022
    Configuration menu
    Copy the full SHA
    cc7ad4e View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. Use python_interpreter_config to silence CMP0087 warning 

    Signed-off-by: Robert Haschke <[email protected]>
    @rhaschke
    rhaschke committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    30db879 View commit details
    Browse the repository at this point in the history