This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 87
fix(reactHtml): renderScripts adding unknown integrity #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +215 B (0%) Total Size: 712 kB
ℹ️ View Unchanged
|
But shouldn't they? |
Yes, but instead of crashing in the client this will more gracefully load the script |
JAdshead
force-pushed
the
fix/render-scripts-integrity
branch
from
November 6, 2023 16:45
e6e3b23
to
e714df7
Compare
JAdshead
force-pushed
the
fix/render-scripts-integrity
branch
from
November 6, 2023 16:46
e714df7
to
7c5e83e
Compare
JAdshead
commented
Nov 7, 2023
dogpatch626
previously approved these changes
Nov 8, 2023
@@ -112,7 +112,7 @@ | |||
"fastify-plugin": "^4.5.1", | |||
"flat": "^5.0.2", | |||
"helmet": "^7.0.0", | |||
"holocron": "^1.8.2", | |||
"holocron": "^1.9.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I this required? If I remember correctly the 1.9.0 release was done unintentionally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it includes the fixes for integrity loading in holocron - americanexpress/holocron#162
JAdshead
force-pushed
the
fix/render-scripts-integrity
branch
from
November 13, 2023 18:20
e1379d2
to
942d8a8
Compare
Matthew-Mallimo
approved these changes
Nov 13, 2023
dogpatch626
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fallback externals do not support legacy, remove legacy logic to ensure does not load missing scripts.
Warn when missing integrity when rendering scripts
Motivation and Context
Fix SSR when fallback externals are required and has no integrity value provided
How Has This Been Tested?
Test suite
Types of Changes
Checklist:
What is the Impact to Developers Using One App?